replicalimits unit tests do not include checks for Scale resources

[skaven81]

The general/replicalimits ConstraintTemplate in the library only has unit tests that validate updates to a Deployment resource. It does not check for Scale resources, which get generated when running kubectl scale commands.

There is also a bug in the Rego because in the event of kubectl scale deploy <name> --replicas=0, the Scale resource has an empty spec (so input.review.object.spec is empty) and a violation is generated, even if a range allows zero as a valid value.

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[maxsmythe]

poke the bot

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.