Skip to content

Fix consistency & don't show CI as failed on missing statuses #1469

Description

@xmo-odoo
  • on github, the PR image the CI meta-entry shows as failed if statuses are missing
Image
  • contrariwise, on the mergebot page the same meta-entry shows as missing / pending even if there are failures:
Image

with the system of delayed / lazy statuses, the first is counter-intuitive. And the second doesn't make much sense given the page does support meta-failure.

So this should be rationalised as:

  • if there's any failure, CI should be failed
  • if there are no failures but there are missing / pending CIs, CI should be pending

edit: xdo thinks if there isn't even a pending on the missing CI, the meta-ci should show as success. Alternatively, maybe there could be an autorun mark? Could be something to check with the designers.

edit2: 3881767b1658a74ff7374545b781483009cc018b might also need to be tuned for that, on the CI page it shows "missing statuses" on the PR if there are missing statuses, but it should probably differentiate between missing (pending) and missing (will be requested)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    Status
    accepted

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions