The logic for selection of Standard vs large file upload appears to be flawed

[ClearviewLED]

If my understanding is correct, the Backblaze LargeFileLimit is usually recommended to be 5GB, the recommededPartSize is suggested to be 100MB. Using the logic below to decide between uploadStandardFile and uploadLargeFile it appears that any file over 100MB will use the uploadLargeFile option. Whereas if my understanding of the Backblaze b2 API is correct only files above 5GB should use the large File methodology.

    if ($options['size'] <= $this->largeFileLimit && $options['size'] <= $this->recommendedPartSize) {
        return $this->uploadStandardFile($options);
    } else {
        return $this->uploadLargeFile($options);
    }

I believe my logic is correct but I am still learning both PHP and the Backblaze API.

Thanks

[robregonm]

@ClearviewLED Does it fail with big files?

[ClearviewLED]

I have an ongoing issue with uploads to Backblaze where a percentage of uploads fail with no error generated. I have added logging in the Guzzle HTTP client which so far has not revealed exactly where the issue is.
It appears to be around the area where each upload or uploadPart starts. It looks like each upload that starts then completes successfully.

Because breaking every upload file apart into 100MB chunks to use the uploadLargeFile upload when they could be uploaded as single files using the uploadStandardFile means that there are a much larger number of files (or file parts) to upload and therefore the chance of a failed upload is much higher.

To reduce the number of failures while I attempt to get to the bottom of the failures I want to ensure that every file up to 5GB is uploaded as a single upload as supported by Backblaze. Hence looking at the logic that selects the upload mode

Thanks

[robregonm]

Could you please send a pull request to fix the issue?