You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Luis approved #196 and #197, but left a set of deployment cleanup notes that are better handled after the current PR batch merges rather than by reopening the docs PRs.
Some of this overlaps with the #186TRUST_PROXY docs blocker, which #215 already tracks as a release prerequisite. This issue is for the remaining production Compose/deployment polish.
Correct any remaining TRUST_PROXY=0 / unset wording in deployment docs after P0: Add per-IP request rate limiting (#166) #185 lands. Unset disables rate limiting; 0 is an explicit direct-exposure setting.
Make the GCP external ALB case explicit in copied deployment comments: bare GCP external ALB needs TRUST_PROXY=2, plus one per extra hop.
Pin or document PG_MAX_CONNECTIONS in the manifest/Compose examples. With the HPA max of 6 replicas, the default pool of 10 plus one readiness client each is already 66 connections against a stock max_connections = 100.
Add a Compose warning for ENABLE_METRICS=true with published 8080:8080: /metrics becomes publicly reachable on a 0.0.0.0 bound host unless the operator restricts access.
Keep termination grace wording aligned across runbook and manifests: 15s preStop, 10s app drain, terminationGracePeriodSeconds: 45.
Context
Luis approved #196 and #197, but left a set of deployment cleanup notes that are better handled after the current PR batch merges rather than by reopening the docs PRs.
Some of this overlaps with the #186
TRUST_PROXYdocs blocker, which #215 already tracks as a release prerequisite. This issue is for the remaining production Compose/deployment polish.Follow-up work
stop_grace_period: 30stodeploy/docker-compose.prod.yml. Docker Compose defaults to 10s, while P1: Graceful shutdown — drain, flush traces, uncaught handlers (#170) #188's defaultSHUTDOWN_TIMEOUT_MSis 20000, so a Compose redeploy can still SIGKILL mid-drain.TRUST_PROXY=0/ unset wording in deployment docs after P0: Add per-IP request rate limiting (#166) #185 lands. Unset disables rate limiting;0is an explicit direct-exposure setting.TRUST_PROXY=2, plus one per extra hop.PG_MAX_CONNECTIONSin the manifest/Compose examples. With the HPA max of 6 replicas, the default pool of 10 plus one readiness client each is already 66 connections against a stockmax_connections = 100.ENABLE_METRICS=truewith published8080:8080:/metricsbecomes publicly reachable on a0.0.0.0bound host unless the operator restricts access.preStop, 10s app drain,terminationGracePeriodSeconds: 45.Acceptance criteria
TRUST_PROXYfrom explicitTRUST_PROXY=0./metricsexposure is called out for Compose.Related