Context
The wave-3 LR2 alignment (commit 7bbf052) implemented the HARD gauge from beatoraja's HARD_LR2 constants. Two details lack first-party LR2 measurements and were noted as open questions in the code comments (packages/player/src/core/groove-gauge.ts):
1. Guts threshold: < 30% vs < 32%
- beatoraja master:
HARD_LR2 guts {30, 0.6} (strict less-than) — currently adopted.
- lr2oraja ≥ 0.8.3 changed it to
< 32 (commit message: "damage reduction start at <32%"), on the theory that LR2's 2%-granular gauge display makes "shows 30%" equal "internal < 32%".
- No first-party measurement found either way.
Action: verify against real LR2 (or a trustworthy measurement) and adjust LR2_HARD_GUTS_THRESHOLD if needed — single constant, tests pin the strict-less-than boundary.
2. Few-notes damage correction (beatoraja's fix2)
beatoraja's MODIFY_DAMAGE includes a second correction based on total note count, but executing the code as written only yields a positive factor for ~10 notes or fewer, and community analysis (ralba) describes behavior that matches a differently-bracketed loop — i.e. the implementation is suspected buggy, and whether real LR2 has a note-count correction at all is unverified. We deliberately implemented only the #TOTAL table (fix1).
Action: determine whether LR2 actually applies a note-count-based damage correction; if yes, implement it with sources.
Sources
Context
The wave-3 LR2 alignment (commit 7bbf052) implemented the HARD gauge from beatoraja's
HARD_LR2constants. Two details lack first-party LR2 measurements and were noted as open questions in the code comments (packages/player/src/core/groove-gauge.ts):1. Guts threshold:
< 30%vs< 32%HARD_LR2guts{30, 0.6}(strict less-than) — currently adopted.< 32(commit message: "damage reduction start at <32%"), on the theory that LR2's 2%-granular gauge display makes "shows 30%" equal "internal < 32%".Action: verify against real LR2 (or a trustworthy measurement) and adjust
LR2_HARD_GUTS_THRESHOLDif needed — single constant, tests pin the strict-less-than boundary.2. Few-notes damage correction (beatoraja's
fix2)beatoraja's
MODIFY_DAMAGEincludes a second correction based on total note count, but executing the code as written only yields a positive factor for ~10 notes or fewer, and community analysis (ralba) describes behavior that matches a differently-bracketed loop — i.e. the implementation is suspected buggy, and whether real LR2 has a note-count correction at all is unverified. We deliberately implemented only the#TOTALtable (fix1).Action: determine whether LR2 actually applies a note-count-based damage correction; if yes, implement it with sources.
Sources
GaugeProperty.java,GrooveGauge.javaGaugeProperty.java, commit 3d649535