Skip to content

No CI, no lockfile, print-based logging only #15

Description

@nsursock

Problem

  • No CI configuration runs the 92-test suite on change.
  • Dependencies are loose (pyproject.toml >= pins) with no lockfile; kaleido==0.2.1 is deprecated.
  • All runtime output is print (main.py:62-67); no structured logging.

Suggested fix

  • Add a minimal CI job (pytest -q on python-version).
  • Add pip-tools/uv lockfile for reproducible installs.
  • Replace print with logging and a --verbose flag in main.py.

Impact

Silent drift, unreproducible installs and opaque failures over time.

Ref: pyproject.toml:10-23; src/dirty_fin_reports/simple/main.py:59-68

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions