Skip to content

Open tab in background doesn't work #18

Description

@Exagone313

When the tabs affected by this add-on are set to be opened in background, the tabs are in fact opened in foreground. I didn't know this was the intended behavior.

The code that should set the previous tab as active has no effect:

if (loadInBackground) {
browser.tabs.update(lastActiveTab.id, { active: true });
}

Proposed solution:

  • open tabs in foreground by default
    • existing users will see a break of behavior, I don't know if the property can be reset (otherwise it can be renamed)
  • fix the bug

Note: I have working code that fixes the bug, but I'm concerned about the breaking change. e8e0392
Note 2: With the fix, it will noticeably move to the new tab then back to the previous tab, but I don't believe it can be corrected (an option could be added to do not set the new tab as active).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions