fix: require an explicit attachment service URL

Author: none23

README.md

@@ -48,14 +48,13 @@ The service URL resolves separately:
 | ---: | --- | --- |
 | 1 | `GITHUB_ATTACHMENTS_URL` in the process environment | Current process override |
 | 2 | `${XDG_CONFIG_HOME:-~/.config}/github-pr-attachments/url` | User-level deployment |
-| 3 | `https://github-pr-attachments.none23.workers.dev` | Backward-compatible default |
 
-Repository `.env` cannot redirect a user-level token to another service. User profile files and repository `.env` are parsed as data, never sourced as shell code.
+The URL is required; there is no shared-service fallback. Repository `.env` cannot redirect a user-level token to another service. User profile files and repository `.env` are parsed as data, never sourced as shell code.
 
 The CLI prints only Markdown by default:
 
 ```markdown
-![Settings after the change](https://github-pr-attachments.none23.workers.dev/a/.../screenshot.png)
+![Settings after the change](https://your-worker.your-subdomain.workers.dev/a/.../screenshot.png)
 ```
 
 Pass `--json` to receive the complete upload response. Diagnostics and errors go to standard error.

bin/config.mjs

@@ -3,8 +3,6 @@ import { homedir } from "node:os";
 import { dirname, join, parse } from "node:path";
 import process from "node:process";
 
-const DEFAULT_SERVICE_URL = "https://github-pr-attachments.none23.workers.dev";
-
 export async function loadConfiguration() {
   const repositoryRoot = await findRepositoryRoot(process.cwd());
   const repository = parseDotEnv(await readOptionalFile(join(repositoryRoot, ".env")));
@@ -24,11 +22,15 @@ export async function loadConfiguration() {
     );
   }
 
+  const serviceUrl = firstValue(process.env.GITHUB_ATTACHMENTS_URL, userUrl);
+  if (serviceUrl === undefined) {
+    throw new Error(
+      "No service URL found in GITHUB_ATTACHMENTS_URL or ~/.config/github-pr-attachments/url",
+    );
+  }
+
   return {
-    serviceUrl: (
-      firstValue(process.env.GITHUB_ATTACHMENTS_URL, userUrl, DEFAULT_SERVICE_URL) ??
-      DEFAULT_SERVICE_URL
-    ).replace(/\/$/, ""),
+    serviceUrl: serviceUrl.replace(/\/$/, ""),
     token,
   };
 }

skills/attach-github-pr-files/scripts/upload.sh

@@ -38,7 +38,7 @@ url_file=$user_config_root/github-pr-attachments/url
 token=
 [ ! -r "$token_file" ] || token=$(sed -n '1p' "$token_file")
 [ -z "${GITHUB_ATTACHMENTS_TOKEN-}" ] || token=$GITHUB_ATTACHMENTS_TOKEN
-service_url=https://github-pr-attachments.none23.workers.dev
+service_url=
 [ ! -r "$url_file" ] || service_url=$(sed -n '1p' "$url_file")
 [ -z "${GITHUB_ATTACHMENTS_URL-}" ] || service_url=$GITHUB_ATTACHMENTS_URL
 
@@ -50,6 +50,10 @@ if [ -z "$token" ]; then
   echo "No upload token found in repository .env, GITHUB_ATTACHMENTS_TOKEN, or ~/.config/github-pr-attachments/token" >&2
   exit 1
 fi
+if [ -z "$service_url" ]; then
+  echo "No service URL found in GITHUB_ATTACHMENTS_URL or ~/.config/github-pr-attachments/url" >&2
+  exit 1
+fi
 
 output=$(mktemp)
 trap 'rm -f "$output"' EXIT HUP INT TERM

test-node/cli.test.mjs

@@ -111,6 +111,32 @@ test("skill uploader reads the user-level service profile", async (context) => {
   assert.equal(result.stdout, EXPECTED_MARKDOWN);
 });
 
+test("CLI refuses to upload without an explicitly configured service URL", async (context) => {
+  const repository = await temporaryRepository(context);
+  const environment = withoutAttachmentConfiguration();
+  environment.GITHUB_ATTACHMENTS_TOKEN = "test-token";
+  environment.XDG_CONFIG_HOME = join(repository, "empty-config");
+
+  const result = await run(process.execPath, [CLI, FIXTURE], environment, repository);
+
+  assert.equal(result.exitCode, 1);
+  assert.match(result.stderr, /No service URL found/);
+  assert.equal(result.stdout, "");
+});
+
+test("skill uploader refuses to upload without an explicitly configured service URL", async (context) => {
+  const repository = await temporaryRepository(context);
+  const environment = withoutAttachmentConfiguration();
+  environment.GITHUB_ATTACHMENTS_TOKEN = "test-token";
+  environment.XDG_CONFIG_HOME = join(repository, "empty-config");
+
+  const result = await run(SKILL_UPLOADER, [FIXTURE], environment, repository);
+
+  assert.equal(result.exitCode, 1);
+  assert.match(result.stderr, /No service URL found/);
+  assert.equal(result.stdout, "");
+});
+
 async function startServer(context, expected) {
   const server = createServer(async (request, response) => {
     assert.equal(request.method, "POST");