Skip to content

Commit f0273ed

Browse files
joyeecheungnodejs-github-bot
authored andcommitted
deps: V8: cherry-pick b2fc93f37507
Original commit message: Avoid backslash at the end of the comments This triggers -Wcomment in GCC. Switch to a different diagram style to avoid it. Change-Id: Iaadabdecb76de21937def43cbac817470a90c735 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8480492 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#110151} Refs: v8/v8@b2fc93f Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #66537 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 26cc118 commit f0273ed

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
# Reset this number to 0 on major V8 upgrades.
4646
# Increment by one for each non-official patch applied to deps/v8.
47-
'v8_embedder_string': '-node.0',
47+
'v8_embedder_string': '-node.1',
4848

4949
##### V8 defaults for Node.js #####
5050

‎deps/v8/include/v8-internal.h‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -467,11 +467,14 @@ constexpr size_t kMaxCppHeapPointers = 0;
467467
//
468468
// As an example, consider the following type hierarchy:
469469
//
470-
// A F
471-
// / \
472-
// B E
473-
// / \
474-
// C D
470+
// A
471+
// +-- B
472+
// | +-- C
473+
// | +-- D
474+
//. |
475+
// +-- E
476+
//
477+
// F
475478
//
476479
// A potential type id assignment for range-based type checks is
477480
// {A: 0, B: 1, C: 2, D: 3, E: 4, F: 5}. With that, the type check for type A

0 commit comments

Comments
 (0)