Skip to content

Commit ea41e65

Browse files
StefanStojanovicnodejs-github-bot
authored andcommitted
deps: define V8_PRESERVE_MOST as no-op on Windows
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools Refs: #55784 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #66537 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent a633547 commit ea41e65

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
# Reset this number to 0 on major V8 upgrades.
4646
# Increment by one for each non-official patch applied to deps/v8.
47-
'v8_embedder_string': '-node.10',
47+
'v8_embedder_string': '-node.11',
4848

4949
##### V8 defaults for Node.js #####
5050

‎deps/v8/include/v8config.h‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -609,11 +609,15 @@ path. Add it with -I<path> to the command line
609609
// functions.
610610
// Use like:
611611
// V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod();
612+
#if V8_OS_WIN
613+
# define V8_PRESERVE_MOST
614+
#else
612615
#if V8_HAS_ATTRIBUTE_PRESERVE_MOST
613616
# define V8_PRESERVE_MOST __attribute__((preserve_most))
614617
#else
615618
# define V8_PRESERVE_MOST /* NOT SUPPORTED */
616619
#endif
620+
#endif
617621

618622

619623
// A macro (V8_DEPRECATED) to mark classes or functions as deprecated.

0 commit comments

Comments
 (0)