Skip to content

Commit 18077b5

Browse files
joyeecheungnodejs-github-bot
authored andcommitted
build: do not match v8_libplatform_headers when scraping sources
Otherwise the target contains undefined symbols because there are only header files in the list. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #66537 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 7e7ff40 commit 18077b5

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎tools/v8_gypfiles/v8.gyp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1780,7 +1780,7 @@
17801780
'v8_libbase',
17811781
],
17821782
'sources': [
1783-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?sources = ")',
1783+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?sources = ")',
17841784
],
17851785
'conditions': [
17861786
['component=="shared_library"', {
@@ -1791,10 +1791,10 @@
17911791
}],
17921792
['v8_use_perfetto==1', {
17931793
'sources!': [
1794-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\-= ")',
1794+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?v8_use_perfetto.*?sources \\-= ")',
17951795
],
17961796
'sources': [
1797-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\+= ")',
1797+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?v8_use_perfetto.*?sources \\+= ")',
17981798
],
17991799
'conditions': [
18001800
['node_shared_perfetto=="false"', {

0 commit comments

Comments
 (0)