Skip to content

Commit 66f9b35

Browse files
Renegade334targos
andcommitted
fix(v8): set RUSTC_BOOTSTRAP=1 when using Cargo nightly features
We need to enable `-Z bindeps` to read the Chromium crates tree, but this is not available on Cargo release builds by default. Setting RUSTC_BOOTSTRAP overrides this behaviour. This is technically an unstable feature, but Chromium's tooling also uses it for the same purpose, and it's extremely unlikely to be withdrawn. Co-authored-by: Michaël Zasso <targos@protonmail.com>
1 parent 984125a commit 66f9b35

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

lib/update-v8/updateCrates.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@ function enumerateTemporalDependencies() {
3737
{
3838
ignoreFailure: false,
3939
captureStdout: true,
40-
spawnArgs: { cwd: path.join(ctx.nodeDir, chromiumCratesDir) }
40+
spawnArgs: {
41+
cwd: path.join(ctx.nodeDir, chromiumCratesDir),
42+
env: { ...process.env, RUSTC_BOOTSTRAP: '1' }
43+
}
4144
}
4245
);
4346
const crates = new Set();

0 commit comments

Comments
 (0)