Skip to content
This repository was archived by the owner on Apr 12, 2022. It is now read-only.
This repository was archived by the owner on Apr 12, 2022. It is now read-only.

Typo in log_variational_posterior computation #2

Description

@shishir13sharma

The return statement should be:
return self.l1.log_variational_posterior
+ self.l2.log_variational_posterior
+ self.l3.log_variational_posterior
instead of the current :
return self.l1.log_variational_posterior
+ self.l2.log_variational_posterior
+ self.l2.log_variational_posterior
Currently, the log posterior of l2 is being counted twice and the log posterior of l3 is not being taken into account at all.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions