From eb541cfc6659262722adb69b05c2a4701143498f Mon Sep 17 00:00:00 2001 From: HYWZ Date: Wed, 1 Nov 2017 17:19:02 +0700 Subject: [PATCH] debug the remove elements. we need this because the line https://github.com/niklasvh/feedback.js/blob/master/feedback.js#L467 ask with an oject. --- feedback.js | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/feedback.js b/feedback.js index 37ba9ef..2d4c56e 100644 --- a/feedback.js +++ b/feedback.js @@ -16,11 +16,25 @@ var log = function( msg ) { }, // function to remove elements, input as arrays removeElements = function( remove ) { - for (var i = 0, len = remove.length; i < len; i++ ) { - var item = Array.prototype.pop.call( remove ); - if ( item !== undefined ) { - if (item.parentNode !== null ) { // check that the item was actually added to DOM - item.parentNode.removeChild( item ); + if (!Array.isArray(remove)) { + Array.prototype.forEach.call( + remove, + function (index, item) { + if (item !== undefined) { + if (item.parentNode !== undefined) { + item.parentNode.removeChild(item); + } + } + } + ); + return; + } + + var item; + for (; item = Array.prototype.pop.call(remove);) { + if (item !== undefined) { + if (item.parentNode !== null) { // check that the item was actually added to DOM + item.parentNode.removeChild(item); } } }