Skip to content

Commit b4a9ae6

Browse files
committed
fix: Log orchestrator cleanup failures instead of empty catch
- log orchestrator empty catch cleanup failures Fixes #29 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
1 parent 6db667e commit b4a9ae6

1 file changed

Lines changed: 12 additions & 5 deletions

File tree

src/lib/orchestrator.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,9 @@ If your work needs human review before it can proceed: mc_report(status: "needs_
910910
await killWindow(session, window);
911911
}
912912
}
913-
} catch {}
913+
} catch (err) {
914+
console.warn("[orchestrator] cleanup step failed:", err);
915+
}
914916

915917
if (worktreePath) {
916918
await removeWorktree(worktreePath, true).catch(() => {});
@@ -1100,7 +1102,9 @@ If your work needs human review before it can proceed: mc_report(status: "needs_
11001102
await killWindow(session, window);
11011103
}
11021104
}
1103-
} catch {}
1105+
} catch (err) {
1106+
console.warn("[orchestrator] cleanup step failed:", err);
1107+
}
11041108

11051109
throw new Error(
11061110
`Failed to relaunch job "${jobName}" for correction: ${error instanceof Error ? error.message : String(error)}`,
@@ -1187,7 +1191,9 @@ If your work needs human review before it can proceed: mc_report(status: "needs_
11871191
status: 'stopped',
11881192
completedAt: new Date().toISOString(),
11891193
});
1190-
} catch {}
1194+
} catch (err) {
1195+
console.warn("[orchestrator] cleanup step failed:", err);
1196+
}
11911197
}
11921198

11931199
await deleteIntegrationBranch(plan.id);
@@ -1280,8 +1286,9 @@ If your work needs human review before it can proceed: mc_report(status: "needs_
12801286
});
12811287
newJob.port = sourceJob.port;
12821288
newJob.launchSessionID = sourceJob.launchSessionID;
1283-
} catch {
1284-
}
1289+
} catch (err) {
1290+
console.warn("[orchestrator] operation failed:", err);
1291+
}
12851292
}
12861293
}
12871294

0 commit comments

Comments
 (0)