From a513a186eb9be0b451d758375193d9d214ddf4bd Mon Sep 17 00:00:00 2001 From: Julien Veyssier Date: Wed, 15 Oct 2025 12:24:19 +0200 Subject: [PATCH] enh: add more detail on the reason why a group does not match the whitelist regex Signed-off-by: Julien Veyssier --- lib/Service/ProvisioningService.php | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/Service/ProvisioningService.php b/lib/Service/ProvisioningService.php index 3dce2faeb..3fa319252 100644 --- a/lib/Service/ProvisioningService.php +++ b/lib/Service/ProvisioningService.php @@ -547,9 +547,16 @@ public function getSyncGroupsOfToken(int $providerId, object $idTokenPayload) { continue; } - if ($groupsWhitelistRegex && !preg_match($groupsWhitelistRegex, $group->gid)) { - $this->logger->debug('Skipped group `' . $group->gid . '` for importing as not part of whitelist'); - continue; + if ($groupsWhitelistRegex) { + $matchResult = preg_match($groupsWhitelistRegex, $group->gid); + if ($matchResult !== 1) { + if ($matchResult === 0) { + $this->logger->debug('Skipped group `' . $group->gid . '` for importing as not part of whitelist (not matching the regex)'); + } else { + $this->logger->debug('Skipped group `' . $group->gid . '` for importing as not part of whitelist (failure when matching)', ['match_result' => $matchResult]); + } + continue; + } } $group->gid = $this->idService->getId($providerId, $group->gid);