Skip to content

Commit 38092ef

Browse files
committed
do not log sensitive data
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
1 parent 3933a24 commit 38092ef

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

lib/Controller/LoginController.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -481,12 +481,12 @@ public function code(string $state = '', string $code = '', string $scope = '',
481481
}
482482

483483
if (!isset($data['id_token'])) {
484-
$this->logger->error('Missing id_token in IdP token response', ['data' => $data]);
484+
$this->logger->error('Missing id_token in IdP token response', ['keys' => array_keys($data)]);
485485
$message = $this->l10n->t('Failed to contact the OIDC provider token endpoint');
486486
return $this->build403TemplateResponse($message, Http::STATUS_FORBIDDEN, [], false);
487487
}
488488

489-
$this->logger->debug('Received code response: ' . json_encode($data, JSON_THROW_ON_ERROR));
489+
$this->logger->debug('Received code response');
490490
$this->eventDispatcher->dispatchTyped(new TokenObtainedEvent($data, $provider, $discovery));
491491

492492
// TODO: proper error handling
@@ -504,19 +504,19 @@ public function code(string $state = '', string $code = '', string $scope = '',
504504
// default is false
505505
if (isset($oidcSystemConfig['enrich_login_id_token_with_userinfo']) && $oidcSystemConfig['enrich_login_id_token_with_userinfo']) {
506506
$userInfo = $this->oidcService->userInfo($provider, $data['access_token']);
507-
$this->logger->debug('[UserInfoEnrich] Enriching the JWT payload with userinfo values', ['userinfo' => $userInfo]);
507+
$this->logger->debug('[UserInfoEnrich] Enriching the JWT payload with userinfo values');
508508
foreach ($userInfo as $key => $value) {
509509
// give priority to id token values, only use userinfo ones if they are missing in the ID token
510510
if (!isset($idTokenPayload->{$key})) {
511511
$idTokenPayload->{$key} = $value;
512-
$this->logger->debug('[UserInfoEnrich] Using userinfo value: ' . $key . ' => ' . $value);
512+
$this->logger->debug('[UserInfoEnrich] Using userinfo key: ' . $key);
513513
}
514514
}
515515
} else {
516516
$this->logger->debug('[UserInfoEnrich] The feature is not enabled');
517517
}
518518

519-
$this->logger->debug('Parsed the JWT payload: ' . json_encode($idTokenPayload, JSON_THROW_ON_ERROR));
519+
$this->logger->debug('Parsed the JWT payload');
520520

521521
if (!isset($idTokenPayload->exp) || $idTokenPayload->exp < $this->timeFactory->getTime()) {
522522
$this->logger->debug('Token expired');

0 commit comments

Comments
 (0)