From ff6ec7cd567b27ac4aca36b7c119c3e5b276c75e Mon Sep 17 00:00:00 2001
From: As3r1408 <chavezpalpanaaronsamuel@gmail.com>
Date: Wed, 2 Sep 2026 14:56:32 +1000
Subject: [PATCH] Fix link bubble behaviour

Signed-off-by: As3r1408 <chavezpalpanaaronsamuel@gmail.com>
---
 src/components/Editor/PreviewOptions.vue | 18 ++++++++++++++----
 src/plugins/links.ts                     | 13 +++++++++++--
 2 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/src/components/Editor/PreviewOptions.vue b/src/components/Editor/PreviewOptions.vue
index 12193ed15db..d02b5fdfdea 100644
--- a/src/components/Editor/PreviewOptions.vue
+++ b/src/components/Editor/PreviewOptions.vue
@@ -4,6 +4,7 @@
 -->
 <template>
 	<NcActions
+		ref="actions"
 		v-model="open"
 		data-text-link-options="select"
 		class="link-options"
@@ -16,7 +17,7 @@
 			data-text-preview-option="text-only"
 			name="preview-option"
 			value="text-only"
-			:modelValue="type"
+			:modelValue="selectedType"
 			@change="(e) => toggle(e.currentTarget.value)">
 			{{ t('text', 'Text only') }}
 		</NcActionRadio>
@@ -24,7 +25,7 @@
 			data-text-preview-option="link-preview"
 			name="preview-option"
 			value="link-preview"
-			:modelValue="type"
+			:modelValue="selectedType"
 			@change="(e) => toggle(e.currentTarget.value)">
 			{{ t('text', 'Show link preview') }}
 		</NcActionRadio>
@@ -116,6 +117,7 @@ export default {
 	data() {
 		return {
 			open: false,
+			selectedType: this.type,
 		}
 	},
 
@@ -125,13 +127,21 @@ export default {
 		},
 	},
 
+	watch: {
+		type(value) {
+			this.selectedType = value
+		},
+
+	},
+
 	methods: {
 		onOpen() {
 			this.$emit('open')
 		},
 
-		toggle(type) {
-			this.open = false
+		async toggle(type) {
+			this.selectedType = type
+			await this.$refs.actions?.closeMenu(false)
 			this.$emit('toggle', type)
 		},
 
diff --git a/src/plugins/links.ts b/src/plugins/links.ts
index 3375054a850..8f052e1c60a 100644
--- a/src/plugins/links.ts
+++ b/src/plugins/links.ts
@@ -109,6 +109,11 @@ export function linkBubble(options: { editor: Editor }) {
 				) {
 					return false
 				}
+
+				// Only show the link bubble while editing.
+				if (!view.editable) {
+					return false
+				}
 				const { state, dispatch } = view
 				const resolved = state.doc.resolve(pos)
 				return setActiveLink(resolved)(state, dispatch)
@@ -184,6 +189,10 @@ export function linkClicking(openLink: (href: string) => void = (href) => {
 					}
 
 					if (event.button === 0) {
+						// In editing mode, let the link bubble handle the click
+						if (view.editable && !event.ctrlKey && !event.metaKey) {
+							return false
+						}
 						// Stop browser from opening the link
 						event.preventDefault()
 
@@ -196,8 +205,8 @@ export function linkClicking(openLink: (href: string) => void = (href) => {
 								target?.scrollIntoView({ block: 'start', behavior: 'smooth' })
 							}
 							window.history.replaceState({}, '', url.href)
-						} else if (event.ctrlKey || event.metaKey) {
-							// Open link directly on Ctrl/Cmd + left click
+						} else {
+							// Open link directly on left click
 							openLink(linkEl.href)
 						}
 					}