diff --git a/lib/Migration/Version030201Date20201116110353.php b/lib/Migration/Version030201Date20201116110353.php index c08f8e2a913..a0d723f8a38 100644 --- a/lib/Migration/Version030201Date20201116110353.php +++ b/lib/Migration/Version030201Date20201116110353.php @@ -11,17 +11,15 @@ use Closure; use OCP\DB\ISchemaWrapper; -use OCP\IConfig; +use OCP\IDBConnection; use OCP\Migration\IOutput; use OCP\Migration\SimpleMigrationStep; class Version030201Date20201116110353 extends SimpleMigrationStep { + private readonly bool $isOracle; - /** @var bool */ - private $isOracle; - - public function __construct(IConfig $config) { - $this->isOracle = $config->getSystemValue('dbtype', 'sqlite') === 'oci'; + public function __construct(IDBConnection $connection) { + $this->isOracle = $connection->getDatabaseProvider() === IDBConnection::PLATFORM_ORACLE; } public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) { @@ -50,6 +48,10 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt return $schema; } + /** + * @param non-empty-string $tableName + * @param non-empty-string $columnName + */ protected function ensureColumnIsNullable(ISchemaWrapper $schema, string $tableName, string $columnName): bool { $table = $schema->getTable($tableName); $column = $table->getColumn($columnName); diff --git a/lib/Migration/Version030201Date20201116123153.php b/lib/Migration/Version030201Date20201116123153.php index 89a8789f8a8..3695de8dc64 100644 --- a/lib/Migration/Version030201Date20201116123153.php +++ b/lib/Migration/Version030201Date20201116123153.php @@ -12,17 +12,15 @@ use Closure; use OCP\DB\ISchemaWrapper; use OCP\DB\Types; -use OCP\IConfig; +use OCP\IDBConnection; use OCP\Migration\IOutput; use OCP\Migration\SimpleMigrationStep; class Version030201Date20201116123153 extends SimpleMigrationStep { + private readonly bool $isOracle; - /** @var bool */ - private $isOracle; - - public function __construct(IConfig $config) { - $this->isOracle = $config->getSystemValue('dbtype', 'sqlite') === 'oci'; + public function __construct(IDBConnection $connection) { + $this->isOracle = $connection->getDatabaseProvider() === IDBConnection::PLATFORM_ORACLE; } public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {