chore: Make classes final and add Override attribute

Signed-off-by: Julius Knorr <jus@bitgrid.net>

Author: juliusknorr

composer.lock

@@ -41,13 +41,14 @@
 use OCP\Files\Events\Node\NodeCopiedEvent;
 use OCP\Files\Template\RegisterTemplateCreatorEvent;
 
-class Application extends App implements IBootstrap {
+final class Application extends App implements IBootstrap {
 	public const APP_NAME = 'text';
 
 	public function __construct(array $params = []) {
 		parent::__construct(self::APP_NAME, $params);
 	}
 
+	#[\Override]
 	public function register(IRegistrationContext $context): void {
 		$context->registerEventListener(RegisterDirectEditorEvent::class, RegisterDirectEditorEventListener::class);
 		$context->registerEventListener(LoadViewer::class, LoadViewerListener::class);
@@ -69,6 +70,7 @@ public function register(IRegistrationContext $context): void {
 		$context->registerMiddleware(SessionMiddleware::class);
 	}
 
+	#[\Override]
 	public function boot(IBootContext $context): void {
 	}
 }

lib/AppInfo/Application.php

@@ -15,7 +15,7 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
-class ResetDocument extends Command {
+final class ResetDocument extends Command {
 	protected DocumentService $documentService;
 
 	public function __construct(DocumentService $documentService) {

lib/Command/ResetDocument.php

@@ -29,7 +29,7 @@
 use OCP\Util;
 use Psr\Log\LoggerInterface;
 
-class AttachmentController extends ApiController implements ISessionAwareController {
+final class AttachmentController extends ApiController implements ISessionAwareController {
 	use TSessionAwareController;
 	public const IMAGE_MIME_TYPES = [
 		'image/png',

lib/Controller/AttachmentController.php

@@ -12,7 +12,7 @@
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\TemplateResponse;
 
-class NavigationController extends Controller {
+final class NavigationController extends Controller {
 
 	/**
 	 *

lib/Controller/NavigationController.php

@@ -21,7 +21,7 @@
 use OCP\Share\IManager as ShareManager;
 use OCP\Share\IShare;
 
-class PublicSessionController extends PublicShareController implements ISessionAwareController {
+final class PublicSessionController extends PublicShareController implements ISessionAwareController {
 	use TSessionAwareController;
 
 	private ?IShare $share = null;
@@ -44,10 +44,12 @@ private function getShare(): IShare {
 		return $this->share;
 	}
 
+	#[\Override]
 	protected function getPasswordHash(): ?string {
 		return $this->getShare()->getPassword();
 	}
 
+	#[\Override]
 	public function isValidToken(): bool {
 		try {
 			$this->share = $this->shareManager->getShareByToken($this->getToken());
@@ -57,6 +59,7 @@ public function isValidToken(): bool {
 		}
 	}
 
+	#[\Override]
 	protected function isPasswordProtected(): bool {
 		/** @psalm-suppress RedundantConditionGivenDocblockType */
 		return $this->getShare()->getPassword() !== null;

lib/Controller/PublicSessionController.php

@@ -23,7 +23,7 @@
 use OCP\IUserManager;
 use OCP\IUserSession;
 
-class SessionController extends ApiController implements ISessionAwareController {
+final class SessionController extends ApiController implements ISessionAwareController {
 	use TSessionAwareController;
 
 	private bool $restoreUser = false;

lib/Controller/SessionController.php

@@ -15,7 +15,7 @@
 use OCP\IConfig;
 use OCP\IRequest;
 
-class SettingsController extends Controller {
+final class SettingsController extends Controller {
 	public const ACCEPTED_KEYS = [
 		'workspace_enabled',
 		'is_full_width_editor'

lib/Controller/SettingsController.php

@@ -20,7 +20,7 @@
 use OCP\IUserManager;
 use OCP\Share\IShare;
 
-class UserApiController extends ApiController implements ISessionAwareController {
+final class UserApiController extends ApiController implements ISessionAwareController {
 	use TSessionAwareController;
 
 	public function __construct(

lib/Controller/UserApiController.php

@@ -55,7 +55,7 @@
 use OCP\Share\IManager;
 use Psr\Log\LoggerInterface;
 
-class WorkspaceController extends OCSController {
+final class WorkspaceController extends OCSController {
 	public function __construct(
 		string $appName,
 		IRequest $request,