chore(refactor): extract PushService from ApiService

Signed-off-by: Max <max@nextcloud.com>

Author: max-nextcloud

lib/Service/ApiService.php

@@ -11,7 +11,6 @@
 
 use Exception;
 use InvalidArgumentException;
-use OCA\NotifyPush\Queue\IQueue;
 use OCA\Text\Context\ContextManager;
 use OCA\Text\Context\IContext;
 use OCA\Text\Context\NewSessionData;
@@ -30,15 +29,14 @@
 
 class ApiService {
 	public function __construct(
-		private readonly ConfigService $configService,
 		private readonly ContextManager $contextManager,
 		private readonly SessionService $sessionService,
 		private readonly DocumentService $documentService,
 		private readonly FileService $fileService,
 		private readonly LoggerInterface $logger,
 		private readonly LockService $lockService,
 		private readonly IL10N $l10n,
-		private readonly ?IQueue $queue,
+		private readonly PushService $pushService,
 	) {
 	}
 
@@ -98,8 +96,7 @@ public function push(Session $session, Document $document, int $version, array $
 			return new DataResponse(['error' => $this->l10n->t('Editing session has expired. Please reload the page.')], Http::STATUS_PRECONDITION_FAILED);
 		}
 		try {
-			$result = $this->documentService->addStep($document, $session, $steps, $version, $recoveryAttempt, $token);
-			$this->addToPushQueue($document, [$awareness, ...array_values($steps)]);
+			$result = $this->pushService->push($session, $document, $version, $steps, $awareness, $recoveryAttempt, $token);
 		} catch (InvalidArgumentException $e) {
 			return new DataResponse(['error' => $e->getMessage()], Http::STATUS_UNPROCESSABLE_ENTITY);
 		} catch (DoesNotExistException) {
@@ -111,27 +108,6 @@ public function push(Session $session, Document $document, int $version, array $
 		return new DataResponse($result);
 	}
 
-	private function addToPushQueue(Document $document, array $steps): void {
-		if ($this->queue === null || !$this->configService->isNotifyPushSyncEnabled()) {
-			return;
-		}
-
-		$sessions = $this->sessionService->getActiveSessions($document->id);
-		$userIds = array_values(array_filter(array_unique(
-			array_map(fn ($session): ?string => $session['userId'], $sessions)
-		)));
-		foreach ($userIds as $userId) {
-			$this->queue->push('notify_custom', [
-				'user' => $userId,
-				'message' => 'text_steps',
-				'body' => [
-					'documentId' => $document->getId(),
-					'steps' => array_values(array_filter($steps)),
-				],
-			]);
-		}
-	}
-
 	public function sync(Session $session, Document $document, int $version = 0, ?string $shareToken = null): DataResponse {
 		$documentId = $session->getDocumentId();
 		$result = [];

lib/Service/PushService.php

@@ -0,0 +1,57 @@
+<?php
+
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Text\Service;
+
+use InvalidArgumentException;
+use OCA\NotifyPush\Queue\IQueue;
+use OCA\Text\Db\Document;
+use OCA\Text\Db\Session;
+use OCP\AppFramework\Db\DoesNotExistException;
+use OCP\Files\NotPermittedException;
+
+class PushService {
+	public function __construct(
+		private readonly ConfigService $configService,
+		private readonly SessionService $sessionService,
+		private readonly DocumentService $documentService,
+		private readonly ?IQueue $queue,
+	) {
+	}
+
+	/**
+	 * @throws InvalidArgumentException
+	 * @throws DoesNotExistException
+	 * @throws NotPermittedException
+	 */
+	public function push(Session $session, Document $document, int $version, array $steps, string $awareness, ?int $recoveryAttempt, ?string $token = null): array {
+		$result = $this->documentService->addStep($document, $session, $steps, $version, $recoveryAttempt, $token);
+		$this->addToPushQueue($document, [$awareness, ...array_values($steps)]);
+		return $result;
+	}
+
+	private function addToPushQueue(Document $document, array $steps): void {
+		if ($this->queue === null || !$this->configService->isNotifyPushSyncEnabled()) {
+			return;
+		}
+		$sessions = $this->sessionService->getActiveSessions($document->id);
+		$userIds = array_values(array_filter(array_unique(
+			array_map(fn ($session): ?string => $session['userId'], $sessions)
+		)));
+		foreach ($userIds as $userId) {
+			$this->queue->push('notify_custom', [
+				'user' => $userId,
+				'message' => 'text_steps',
+				'body' => [
+					'documentId' => $document->getId(),
+					'steps' => array_values(array_filter($steps)),
+				],
+			]);
+		}
+	}
+
+}