fix(share): detect if documentId is outside of share early

Signed-off-by: Max <max@nextcloud.com>

Author: max-nextcloud

lib/Middleware/SessionMiddleware.php

@@ -23,6 +23,8 @@
 use OCP\AppFramework\Http\Response;
 use OCP\AppFramework\Middleware;
 use OCP\Constants;
+use OCP\Files\File;
+use OCP\Files\Folder;
 use OCP\Files\IRootFolder;
 use OCP\Files\NotPermittedException;
 use OCP\IL10N;
@@ -148,6 +150,17 @@ private function assertUserOrShareToken(ISessionAwareController $controller): vo
 				throw new InvalidSessionException();
 			}
 
+			if ($share->getNodeType() === 'folder') {
+				$folder = $share->getNode();
+				if (!$folder instanceof Folder) {
+					throw new InvalidSessionException();
+				}
+				$file = $folder->getFirstNodeById($documentId);
+				if (!$file instanceof File) {
+					throw new InvalidSessionException();
+				}
+			}
+
 			if ($share->getPassword() !== null) {
 				$shareIds = $this->session->get('public_link_authenticated');
 				$shareIds = is_array($shareIds) ? $shareIds : [$shareIds];