From 5a321dd5b4c0cac06f7c29e1d0f7772592b5a0c0 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Thu, 27 Aug 2026 11:57:48 +0200 Subject: [PATCH] fix(chat): Avoid NPE when opening a file attachment in the Files app message.activeUser is a deprecated field that is no longer populated for messages loaded via chatViewModel.getMessageById(), causing openInFilesApp to crash on the !! assertion. Use the activity's own conversationUser instead, and guard against empty file id/link. Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Marcel Hibbe --- app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt b/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt index 9e1b0aa482..3c07c07183 100644 --- a/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt +++ b/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt @@ -3920,8 +3920,12 @@ class ChatActivity : fun openInFilesApp(message: ChatMessage) { val keyID = message.fileParameters.id val link = message.fileParameters.link - val fileViewerUtils = FileViewerUtils(this, message.activeUser!!) - fileViewerUtils.openFileInFilesApp(link!!, keyID!!) + if (keyID.isEmpty() || link.isEmpty()) { + Snackbar.make(binding.root, R.string.nc_common_error_sorry, Snackbar.LENGTH_LONG).show() + return + } + val fileViewerUtils = FileViewerUtils(this, conversationUser) + fileViewerUtils.openFileInFilesApp(link, keyID) } private fun hasVisibleItems(message: ChatMessage): Boolean =