Commit 28401e6
committed
feat(moderators): Show the participant sheet to non-moderators too
The participants list carries owner and moderator as an icon only. Anyone
without moderation rights had no way to read it: the row was clickable but
inert, so the rank had no text form for them anywhere in the app.
Open the sheet for everyone. Without moderation rights it renders the header -
display name and role - and no action rows, which is exactly the information the
icon was withholding. The attendee PIN stays hidden as well; it is a SIP
credential the server only hands to moderators.
Hiding rows is presentation, not access control, so the canModerate() check does
not simply disappear into the sheet: it moves to handleParticipantOpsAction,
where it guards the API call itself rather than the drawing of a button.
Assisted-by: Claude Code:claude-opus-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>1 parent 2e71f8e commit 28401e6
3 files changed
Lines changed: 38 additions & 16 deletions
File tree
- app/src/main
- java/com/nextcloud/talk/conversationinfo
- ui
- res/values
Lines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
727 | 727 | | |
728 | 728 | | |
729 | 729 | | |
730 | | - | |
731 | 730 | | |
732 | | - | |
733 | | - | |
734 | | - | |
735 | | - | |
736 | | - | |
737 | 731 | | |
738 | 732 | | |
739 | 733 | | |
| 734 | + | |
740 | 735 | | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
741 | 740 | | |
742 | 741 | | |
743 | 742 | | |
| |||
Lines changed: 32 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
| |||
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| 77 | + | |
76 | 78 | | |
77 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
78 | 83 | | |
79 | 84 | | |
80 | 85 | | |
| |||
352 | 357 | | |
353 | 358 | | |
354 | 359 | | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
355 | 379 | | |
356 | 380 | | |
357 | 381 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
469 | 469 | | |
470 | 470 | | |
471 | 471 | | |
472 | | - | |
473 | | - | |
| 472 | + | |
474 | 473 | | |
475 | 474 | | |
476 | 475 | | |
| |||
0 commit comments