feat(sharereview): expose tables(table/view/context) shares to share-review apps via OCP\Share\ShareReview

Implement IShareReviewSource listing all tables(table/view/context) shares
with their capabilities mapped to ShareReviewPermission entries, streaming
share rows from the database via a generator to keep the memory footprint
low on large instances, gate deletions behind the
ShareReviewAccessCheckEvent authorization check with share-delete activity
entries for auditability, and register the source via
RegisterShareReviewSourceEvent.

Assisted-by: Claude Code:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Author: AndyScherzinger

lib/AppInfo/Application.php

@@ -34,6 +34,7 @@
 use OCA\Tables\Search\SearchTablesProvider;
 use OCA\Tables\Service\Support\AuditLogServiceInterface;
 use OCA\Tables\Service\Support\DefaultAuditLogService;
+use OCA\Tables\ShareReview\ShareReviewListener;
 use OCA\Tables\UserMigration\TablesMigrator;
 use OCP\AppFramework\App;
 use OCP\AppFramework\Bootstrap\IBootContext;
@@ -44,6 +45,7 @@
 use OCP\Collaboration\Resources\LoadAdditionalScriptsEvent;
 use OCP\DB\Events\AddMissingIndicesEvent;
 use OCP\Group\Events\GroupDeletedEvent;
+use OCP\Share\ShareReview\RegisterShareReviewSourceEvent;
 use OCP\User\Events\BeforeUserDeletedEvent;
 use OCP\User\Events\UserDeletedEvent;
 use Psr\Container\ContainerInterface;
@@ -84,6 +86,7 @@ public function register(IRegistrationContext $context): void {
 
 		$context->registerEventListener(BeforeUserDeletedEvent::class, UserDeletedListener::class);
 		$context->registerEventListener(DatasourceEvent::class, AnalyticsDatasourceListener::class);
+		$context->registerEventListener(RegisterShareReviewSourceEvent::class, ShareReviewListener::class);
 		$context->registerEventListener(RenderReferenceEvent::class, TablesReferenceListener::class);
 		$context->registerEventListener(BeforeTemplateRenderedEvent::class, BeforeTemplateRenderedListener::class);
 		$context->registerEventListener(LoadAdditionalScriptsEvent::class, LoadAdditionalListener::class);

lib/Db/ContextMapper.php

@@ -19,6 +19,8 @@
 
 /** @template-extends QBMapper<Context> */
 class ContextMapper extends QBMapper {
+	private const DB_CHUNK_SIZE = 1_000;
+
 	protected string $table = 'tables_contexts_context';
 
 	public function __construct(
@@ -279,6 +281,33 @@ public function findAllContainingNode(int $nodeType, int $nodeId, string $userId
 		return $resultEntities;
 	}
 
+	/**
+	 * Fetch a map of id → name for the given context IDs.
+	 *
+	 * @param int[] $ids
+	 * @return array<int, string>
+	 * @throws Exception
+	 */
+	public function findIdToNameMap(array $ids): array {
+		if ($ids === []) {
+			return [];
+		}
+		$qb = $this->db->getQueryBuilder();
+		$qb->select('id', 'name')
+			->from($this->table)
+			->where($qb->expr()->in('id', $qb->createParameter('ids')));
+		$map = [];
+		foreach (array_chunk($ids, self::DB_CHUNK_SIZE) as $chunk) {
+			$qb->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY);
+			$result = $qb->executeQuery();
+			foreach ($result->fetchAll() as $row) {
+				$map[(int)$row['id']] = (string)$row['name'];
+			}
+			$result->closeCursor();
+		}
+		return $map;
+	}
+
 	protected function applyOwnedOrSharedQuery(IQueryBuilder $qb, string $userId): void {
 		$sharedToConditions = $qb->expr()->orX();
 

lib/Db/ShareMapper.php

@@ -236,6 +236,54 @@ public function findAllSharesForTablesAndContexts(array $tableIds, array $contex
 		return $this->findEntities($qb);
 	}
 
+	/**
+	 * Yield all shares as raw associative arrays, ordered by id.
+	 *
+	 * Implemented as a generator so the full share list is never held in
+	 * memory alongside whatever the consumer builds from it.
+	 *
+	 * @return \Generator<int, array<string, mixed>>
+	 * @throws Exception
+	 */
+	public function findAllRaw(): \Generator {
+		$qb = $this->db->getQueryBuilder();
+		$qb->select(
+			'id', 'sender', 'receiver', 'receiver_type', 'node_id', 'node_type',
+			'token', 'password',
+			'permission_read', 'permission_create', 'permission_update',
+			'permission_delete', 'permission_manage',
+			'created_at', 'last_edit_at'
+		)->from($this->table)
+			->orderBy('id', 'ASC');
+		$result = $qb->executeQuery();
+		try {
+			while (($row = $result->fetch()) !== false) {
+				yield $row;
+			}
+		} finally {
+			$result->closeCursor();
+		}
+	}
+
+	/**
+	 * Fetch the distinct node IDs that have shares, grouped by node type.
+	 *
+	 * @return array<string, list<int>>
+	 * @throws Exception
+	 */
+	public function findSharedNodeIdsByType(): array {
+		$qb = $this->db->getQueryBuilder();
+		$qb->selectDistinct(['node_id', 'node_type'])
+			->from($this->table);
+		$result = $qb->executeQuery();
+		$nodeIdsByType = [];
+		while (($row = $result->fetch()) !== false) {
+			$nodeIdsByType[(string)$row['node_type']][] = (int)$row['node_id'];
+		}
+		$result->closeCursor();
+		return $nodeIdsByType;
+	}
+
 	/**
 	 * @throws Exception
 	 */

lib/Db/TableMapper.php

@@ -19,6 +19,8 @@
 
 /** @template-extends QBMapper<Table> */
 class TableMapper extends QBMapper {
+	private const DB_CHUNK_SIZE = 1_000;
+
 	protected string $table = 'tables_tables';
 	protected CappedMemoryCache $cache;
 	public function __construct(
@@ -176,4 +178,31 @@ public function insert(Entity $entity): Table {
 	public function getDbConnection() {
 		return $this->db;
 	}
+
+	/**
+	 * Fetch a map of id → title for the given table IDs.
+	 *
+	 * @param int[] $ids
+	 * @return array<int, string>
+	 * @throws Exception
+	 */
+	public function findIdToTitleMap(array $ids): array {
+		if ($ids === []) {
+			return [];
+		}
+		$qb = $this->db->getQueryBuilder();
+		$qb->select('id', 'title')
+			->from($this->table)
+			->where($qb->expr()->in('id', $qb->createParameter('ids')));
+		$map = [];
+		foreach (array_chunk($ids, self::DB_CHUNK_SIZE) as $chunk) {
+			$qb->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY);
+			$result = $qb->executeQuery();
+			foreach ($result->fetchAll() as $row) {
+				$map[(int)$row['id']] = (string)$row['title'];
+			}
+			$result->closeCursor();
+		}
+		return $map;
+	}
 }

lib/Db/ViewMapper.php

@@ -19,6 +19,8 @@
 
 /** @template-extends QBMapper<View> */
 class ViewMapper extends QBMapper {
+	private const DB_CHUNK_SIZE = 1_000;
+
 	protected string $table = 'tables_views';
 
 	protected CappedMemoryCache $cache;
@@ -178,4 +180,31 @@ public function search(?string $term = null, ?string $userId = null, ?int $limit
 
 		return $this->findEntities($qb);
 	}
+
+	/**
+	 * Fetch a map of id → title for the given view IDs.
+	 *
+	 * @param int[] $ids
+	 * @return array<int, string>
+	 * @throws Exception
+	 */
+	public function findIdToTitleMap(array $ids): array {
+		if ($ids === []) {
+			return [];
+		}
+		$qb = $this->db->getQueryBuilder();
+		$qb->select('id', 'title')
+			->from($this->table)
+			->where($qb->expr()->in('id', $qb->createParameter('ids')));
+		$map = [];
+		foreach (array_chunk($ids, self::DB_CHUNK_SIZE) as $chunk) {
+			$qb->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY);
+			$result = $qb->executeQuery();
+			foreach ($result->fetchAll() as $row) {
+				$map[(int)$row['id']] = (string)$row['title'];
+			}
+			$result->closeCursor();
+		}
+		return $map;
+	}
 }

lib/Service/ShareService.php

@@ -767,6 +767,25 @@ private function addReceiverDisplayNames(array $shares): array {
 		return $shares;
 	}
 
+	/**
+	 * Delete a share on behalf of a trusted share-review operation.
+	 *
+	 * PERMISSION_MANAGE is intentionally not checked. The caller must verify
+	 * operator access via ShareReviewAccessCheckEvent before invoking this
+	 * method. All other side effects are preserved so the deletion is auditable.
+	 *
+	 * @throws \OCP\AppFramework\Db\DoesNotExistException if $id does not exist
+	 * @throws Exception on database failure
+	 */
+	public function deleteForShareReview(int $id): void {
+		$share = $this->mapper->find($id);
+		$this->triggerShareActivity($share, ActivityManager::SUBJECT_SHARE_DELETE);
+		$this->mapper->delete($share);
+		if ($share->getNodeType() === 'context') {
+			$this->contextNavigationMapper->deleteByShareId($share->getId());
+		}
+	}
+
 	public function deleteAllForTable(Table $table):void {
 		try {
 			$this->mapper->deleteByNode($table->getId(), 'table');

lib/ShareReview/ShareReviewListener.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Tables\ShareReview;
+
+use OCP\EventDispatcher\Event;
+use OCP\EventDispatcher\IEventListener;
+use OCP\Share\ShareReview\RegisterShareReviewSourceEvent;
+
+/** @template-implements IEventListener<RegisterShareReviewSourceEvent> */
+class ShareReviewListener implements IEventListener {
+	public function __construct() {
+	}
+
+	public function handle(Event $event): void {
+		if (!$event instanceof RegisterShareReviewSourceEvent) {
+			return;
+		}
+		$event->registerSource(ShareReviewSource::class);
+	}
+}