rename migration file / update handleColumnPersistDbException return type / use attributes instead of doc annotation

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

Author: samin-z

…ration/Version1000Date20260327000000.php …ration/Version2200Date20260707000000.phplib/Migration/Version1000Date20260327000000.php renamed to lib/Migration/Version2200Date20260707000000.php lib/Migration/Version1000Date20260327000000.php renamed to lib/Migration/Version2200Date20260707000000.php

@@ -18,7 +18,7 @@
 use OCP\Migration\SimpleMigrationStep;
 use Override;
 
-class Version1000Date20260327000000 extends SimpleMigrationStep {
+class Version2200Date20260707000000 extends SimpleMigrationStep {
 	private IDBConnection $connection;
 
 	public function __construct(IDBConnection $connection) {
@@ -79,6 +79,6 @@ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array
 			$result->closeCursor();
 		}
 
-		$output->info('Version1000Date20260327000000: backfilled technical_name for ' . $updatedCount . ' columns.');
+		$output->info('Version2200Date20260707000000: backfilled technical_name for ' . $updatedCount . ' columns.');
 	}
 }

lib/Service/ColumnService.php

@@ -746,7 +746,7 @@ private function buildDefaultTechnicalName(int $columnId): string {
 	 * @throws BadRequestError
 	 * @throws InternalError
 	 */
-	private function handleColumnPersistDbException(\OCP\DB\Exception $e, string $context): void {
+	private function handleColumnPersistDbException(\OCP\DB\Exception $e, string $context): never {
 		if ($e->getReason() === \OCP\DB\Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
 			throw new BadRequestError('Technical name must be unique in the table.');
 		}

tests/unit/Validation/ColumnDtoValidatorTest.php

@@ -12,6 +12,7 @@
 use OCA\Tables\Dto\Column as ColumnDto;
 use OCA\Tables\Errors\BadRequestError;
 use OCA\Tables\Validation\ColumnDtoValidator;
+use PHPUnit\Framework\Attributes\DataProvider;
 use Test\TestCase;
 
 class ColumnDtoValidatorTest extends TestCase {
@@ -53,9 +54,7 @@ public function testTechnicalNameOver200CharsIsRejected(): void {
 		$this->validator->validate($this->dto('test' . str_repeat('t', 197)));
 	}
 
-	/**
-	 * @dataProvider reservedNameProvider
-	 */
+	#[DataProvider('reservedNameProvider')]
 	public function testReservedTechnicalNamesAreRejected(string $name): void {
 		$this->expectException(BadRequestError::class);
 		$this->expectExceptionMessageMatches('/reserved/i');
@@ -73,9 +72,7 @@ public static function reservedNameProvider(): array {
 		];
 	}
 
-	/**
-	 * @dataProvider invalidFormatProvider
-	 */
+	#[DataProvider('invalidFormatProvider')]
 	public function testInvalidFormatIsRejected(string $name): void {
 		$this->expectException(BadRequestError::class);
 		$this->expectExceptionMessageMatches('/start with a letter|lowercase|underscores/i');
@@ -93,9 +90,7 @@ public static function invalidFormatProvider(): array {
 		];
 	}
 
-	/**
-	 * @dataProvider validFormatProvider
-	 */
+	#[DataProvider('validFormatProvider')]
 	public function testValidFormatIsAccepted(string $name): void {
 		$this->expectNotToPerformAssertions();
 		$this->validator->validate($this->dto($name));