fix: clamp number decimal precision

Signed-off-by: xhon-pelushi <xhon@pelushi.com>

Author: xhon-pelushi

cypress/component/TableCellNumber.cy.js

@@ -5,6 +5,7 @@
 import { setLocale } from '@nextcloud/l10n'
 
 import TableCellNumber from '../../src/shared/components/ncTable/partials/TableCellNumber.vue'
+import NumberForm from '../../src/shared/components/ncTable/partials/rowTypePartials/NumberForm.vue'
 
 describe('TableCellNumber', () => {
 	beforeEach(() => {
@@ -26,9 +27,23 @@ describe('TableCellNumber', () => {
 	})
 
 	it('clamps out-of-range decimal counts for Intl.NumberFormat', () => {
-		mountNumberCell(1.234567, { numberDecimals: 50 })
+		mountNumberCell(1.2, { numberDecimals: 101 })
 
-		cy.get('.number-display').should('contain.text', '1.234567')
+		cy.get('.number-display').invoke('text').should((text) => {
+			expect(text).to.match(/^1\.20+$/)
+			expect(text.trim().split('.')[1]).to.have.length(100)
+		})
+	})
+
+	it('clamps out-of-range decimal counts when editing row values', () => {
+		mountRowNumberForm(1.2, { numberDecimals: 101 }).then(({ wrapper }) => {
+			expect(wrapper.vm.numberFractionDigits).to.equal(100)
+			expect(wrapper.vm.parseValue('1.234')).to.equal(1.234)
+			expect(wrapper.vm.getStep).to.match(/^\.0+1$/)
+
+			const step = wrapper.vm.getStep
+			expect(step.slice(1, -1)).to.have.length(99)
+		})
 	})
 })
 
@@ -49,3 +64,32 @@ function mountNumberCell(value, columnOverrides = {}) {
 		},
 	})
 }
+
+function mountRowNumberForm(value, columnOverrides = {}) {
+	return cy.mount(NumberForm, {
+		props: {
+			column: {
+				id: 1,
+				title: 'Amount',
+				description: '',
+				mandatory: false,
+				numberDecimals: 0,
+				numberDefault: undefined,
+				numberMax: null,
+				numberMin: null,
+				numberPrefix: '',
+				numberSuffix: '',
+				viewColumnInformation: {},
+				...columnOverrides,
+			},
+			value,
+		},
+		global: {
+			components: {
+				RowFormWrapper: {
+					template: '<div><slot /></div>',
+				},
+			},
+		},
+	})
+}

src/shared/components/ncTable/partials/TableCellNumber.vue

@@ -43,10 +43,10 @@ export default {
 			if (this.value === null) {
 				return null
 			}
-			// Intl.NumberFormat only accepts 0..20 fraction digits
+			// Intl.NumberFormat only accepts 0..100 fraction digits
 			const raw = Number(this.column?.numberDecimals ?? 0)
 			const fractionDigits = Number.isFinite(raw)
-				? Math.min(20, Math.max(0, Math.trunc(raw)))
+				? Math.min(100, Math.max(0, Math.trunc(raw)))
 				: 0
 			return new Intl.NumberFormat(getCanonicalLocale(), {
 				maximumFractionDigits: fractionDigits,

src/shared/components/ncTable/partials/columnTypePartials/forms/NumberForm.vue

@@ -19,7 +19,7 @@
 					{{ t('tables', 'Decimals') }}
 				</div>
 				<div class="fix-col-4">
-					<input v-model="mutableColumn.numberDecimals" type="number">
+					<input v-model="mutableColumn.numberDecimals" type="number" min="0" max="100" step="1">
 				</div>
 			</div>
 			<div v-if="defaultValueErrorHint !== ''" class="col-4">

src/shared/components/ncTable/partials/rowTypePartials/NumberForm.vue

@@ -43,11 +43,17 @@ export default {
 		'update:value',
 	],
 	computed: {
+		numberFractionDigits() {
+			const raw = Number(this.column?.numberDecimals ?? 0)
+			return Number.isFinite(raw)
+				? Math.min(100, Math.max(0, Math.trunc(raw)))
+				: 0
+		},
 		getStep() {
-			if (this.column?.numberDecimals === 0) {
+			if (this.numberFractionDigits === 0) {
 				return '1'
-			} else if (this.column?.numberDecimals > 0) {
-				return '.' + '0'.repeat(this.column.numberDecimals - 1) + '1'
+			} else if (this.numberFractionDigits > 0) {
+				return '.' + '0'.repeat(this.numberFractionDigits - 1) + '1'
 			} else {
 				return 'any'
 			}
@@ -95,7 +101,7 @@ export default {
 			} else {
 				parsedValue = inputValue
 			}
-			const roundedValue = parsedValue.toFixed(this.column?.numberDecimals)
+			const roundedValue = parsedValue.toFixed(this.numberFractionDigits)
 			let value = parseFloat(roundedValue)
 			if ((this.column?.numberMin !== null && this.column?.numberMin !== undefined) && value < this.column?.numberMin) {
 				value = this.column.numberMin