feat(federation): delete table on receiving instance if the federated share is deleted

Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>

Author: benjaminfrueh

lib/Service/FederationService.php

@@ -109,22 +109,6 @@ public function deleteRow(Table $table, int $rowId): array {
 		}
 	}
 
-	public function notifyTableDeleted(Table $table): void {
-		try {
-			$shares = $this->shareMapper->findRemoteSharesForNode($table->getId(), 'table');
-		} catch (\Exception $e) {
-			$this->logger->warning('Could not fetch remote shares for table deletion notification', ['exception' => $e]);
-			return;
-		}
-		foreach ($shares as $share) {
-			$this->proxy->sendNotification(
-				FederationProvider::NOTIFICATION_DELETE_TABLE,
-				(string)$table->getId(),
-				$share,
-			);
-		}
-	}
-
 	public function sendShare(Share $share): void {
 		$cloudId = $this->cloudIdManager->resolveCloudId($share->getReceiver());
 		$ownerCloudId = $this->cloudIdManager->getCloudId($share->getSender(), null);
@@ -151,6 +135,22 @@ public function sendShare(Share $share): void {
 		}
 	}
 
+	public function notifyTableDeleted(Table $table): void {
+		try {
+			$shares = $this->shareMapper->findRemoteSharesForNode($table->getId(), 'table');
+		} catch (\Exception $e) {
+			$this->logger->warning('Could not fetch remote shares for table deletion notification', ['exception' => $e]);
+			return;
+		}
+		foreach ($shares as $share) {
+			$this->proxy->sendNotification(
+				FederationProvider::NOTIFICATION_DELETE_TABLE,
+				(string)$table->getId(),
+				$share,
+			);
+		}
+	}
+
 	public function notifyPermissionUpdate(Share $share): void {
 		$this->proxy->sendNotification(
 			FederationProvider::NOTIFICATION_UPDATE_PERMISSIONS,
@@ -184,4 +184,12 @@ public function notifyTableUpdate(Table $table): void {
 			);
 		}
 	}
+
+	public function notifyShareDelete(Share $share): void {
+		$this->proxy->sendNotification(
+			FederationProvider::NOTIFICATION_DELETE_TABLE,
+			(string)$share->getNodeId(),
+			$share,
+		);
+	}
 }

lib/Service/ShareService.php

@@ -666,6 +666,12 @@ public function delete(int $id): Share {
 
 		try {
 			$this->mapper->delete($item);
+
+			// notify federated shares about share deletion
+			if ($item->getReceiverType() === ShareReceiverType::REMOTE) {
+				$this->federationService->notifyShareDelete($item);
+			}
+
 			if ($item->getNodeType() === 'context') {
 				$this->contextNavigationMapper->deleteByShareId($item->getId());
 			}