Skip to content

Commit a5b68d7

Browse files
fix(tables): move pin action to top of column menu and close on click
AI-assistant: Claude Code v2.1.114 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
1 parent 14ce77f commit a5b68d7

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

src/shared/components/ncTable/partials/TableHeaderColumnOptions.vue

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,13 @@
6161
</NcActionButton>
6262
</template>
6363
<template v-else>
64+
<NcActionButton v-if="column.id >= 0" @click="pinColumn()">
65+
<template #icon>
66+
<PinOffIcon v-if="pinnedColumnId === column.id" :size="20" />
67+
<PinIcon v-else :size="20" />
68+
</template>
69+
{{ pinnedColumnId === column.id ? t('tables', 'Unpin column') : t('tables', 'Pin column') }}
70+
</NcActionButton>
6471
<NcActionCaption v-if="!hasPresetSorting && canSort" :name="t('tables', 'Sorting')" />
6572
<NcActionButtonGroup v-if="!hasPresetSorting && canSort">
6673
<NcActionButton :class="{ selected: getSortMode === 'ASC' }" :aria-label="t('tables', 'Sort asc')" @click="sort('ASC')">
@@ -118,13 +125,6 @@
118125
</template>
119126
</NcActionButton>
120127
</NcActionButtonGroup>
121-
<NcActionButton v-if="column.id >= 0" @click="$emit('pin-column', column.id)">
122-
<template #icon>
123-
<PinOffIcon v-if="pinnedColumnId === column.id" :size="20" />
124-
<PinIcon v-else :size="20" />
125-
</template>
126-
{{ pinnedColumnId === column.id ? t('tables', 'Unpin column') : t('tables', 'Pin column') }}
127-
</NcActionButton>
128128
</template>
129129
</NcActions>
130130
</div>
@@ -326,6 +326,10 @@ export default {
326326
close() {
327327
this.localOpenState = false
328328
},
329+
pinColumn() {
330+
this.$emit('pin-column', this.column.id)
331+
this.close()
332+
},
329333
changeFilterOperator(op) {
330334
this.selectedOperator = op
331335
this.selectOperator = false

0 commit comments

Comments
 (0)