fix: psalm

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>

Author: enjeck

lib/Activity/ActivityManager.php

@@ -642,7 +642,7 @@ private function formatRowActivity(\OCP\IL10N $l, string $subjectIdentifier, arr
 		}
 	}
 
-	private function formatRowUpdateActivity($l, array $subjectParams, bool $ownActivity, bool $isViewContext): string {
+	private function formatRowUpdateActivity(\OCP\IL10N $l, array $subjectParams, bool $ownActivity, bool $isViewContext): string {
 		$visibleChangeCols = $this->getVisibleChangeCols($subjectParams);
 		$columns = '';
 		$count = 1;

lib/AppInfo/Application.php

@@ -128,7 +128,7 @@ public function register(IRegistrationContext $context): void {
 	}
 
 	public function boot(IBootContext $context): void {
-		$context->injectFn([$this, 'registerCloudFederationProviderManager']);
+		$context->injectFn($this->registerCloudFederationProviderManager(...));
 	}
 
 	public function registerCloudFederationProviderManager(ICloudFederationProviderManager $manager): void {

lib/Controller/RowOCSController.php

@@ -39,9 +39,9 @@ public function __construct(
 		IL10N $n,
 		string $userId,
 		protected RowService $rowService,
-		private TableService $tableService,
-		private ViewService $viewService,
-		private FederationService $federationService,
+		private readonly TableService $tableService,
+		private readonly ViewService $viewService,
+		private readonly FederationService $federationService,
 	) {
 		parent::__construct($request, $logger, $n, $userId);
 	}

lib/Federation/FederationProvider.php

@@ -36,11 +36,11 @@ class FederationProvider implements ISignedCloudFederationProvider {
 	public const NOTIFICATION_UPDATE_NODE = 'update-node';
 
 	public function __construct(
-		private TableMapper $tableMapper,
-		private ViewMapper $viewMapper,
-		private ShareMapper $shareMapper,
-		private ICloudIdManager $cloudIdManager,
-		private FederationService $federationService,
+		private readonly TableMapper $tableMapper,
+		private readonly ViewMapper $viewMapper,
+		private readonly ShareMapper $shareMapper,
+		private readonly ICloudIdManager $cloudIdManager,
+		private readonly FederationService $federationService,
 	) {
 	}
 

lib/Federation/FederationProxy.php

@@ -30,16 +30,16 @@
 
 class FederationProxy {
 	public function __construct(
-		private IClientService $clientService,
-		private IUserSession $userSession,
-		private IConfig $config,
-		private IFactory $l10nFactory,
-		private LoggerInterface $logger,
-		private ICloudFederationProviderManager $federationProviderManager,
-		private ICloudFederationFactory $federationFactory,
-		private ICloudIdManager $cloudIdManager,
-		private ISignatureManager $signatureManager,
-		private ISignatoryManager $signatoryManager,
+		private readonly IClientService $clientService,
+		private readonly IUserSession $userSession,
+		private readonly IConfig $config,
+		private readonly IFactory $l10nFactory,
+		private readonly LoggerInterface $logger,
+		private readonly ICloudFederationProviderManager $federationProviderManager,
+		private readonly ICloudFederationFactory $federationFactory,
+		private readonly ICloudIdManager $cloudIdManager,
+		private readonly ISignatureManager $signatureManager,
+		private readonly ISignatoryManager $signatoryManager,
 	) {
 	}
 
@@ -170,7 +170,7 @@ private function prepareSignedRequestOptions(string $verb, string $url, ?string
 		);
 
 		if (!empty($parameters)) {
-			$options['json'] = json_decode($options['body'], true);
+			$options['json'] = json_decode((string) $options['body'], true);
 			unset($options['body']);
 		}
 

lib/Service/FederationService.php

@@ -31,16 +31,16 @@
 
 class FederationService {
 	public function __construct(
-		private FederationProxy $proxy,
-		private ICloudIdManager $cloudIdManager,
-		private LoggerInterface $logger,
-		private ShareMapper $shareMapper,
-		private TableMapper $tableMapper,
-		private ViewMapper $viewMapper,
-		private UserHelper $userHelper,
-		private ICloudFederationProviderManager $federationProviderManager,
-		private ICloudFederationFactory $federationFactory,
-		private ConfigService $configService,
+		private readonly FederationProxy $proxy,
+		private readonly ICloudIdManager $cloudIdManager,
+		private readonly LoggerInterface $logger,
+		private readonly ShareMapper $shareMapper,
+		private readonly TableMapper $tableMapper,
+		private readonly ViewMapper $viewMapper,
+		private readonly UserHelper $userHelper,
+		private readonly ICloudFederationProviderManager $federationProviderManager,
+		private readonly ICloudFederationFactory $federationFactory,
+		private readonly ConfigService $configService,
 	) {
 	}