fix: lint and rector

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>

Author: enjeck

lib/Controller/ViewController.php

@@ -57,9 +57,7 @@ public function show(int $id): DataResponse {
 	#[NoAdminRequired]
 	#[RequirePermission(permission: Application::PERMISSION_MANAGE, type: Application::NODE_TYPE_TABLE, idParam: 'tableId')]
 	public function create(int $tableId, string $title, ?string $emoji, ?string $layout = null): DataResponse {
-		return $this->handleError(function () use ($tableId, $title, $emoji, $layout) {
-			return $this->service->create($title, $emoji, $this->getTable($tableId, true), null, layout: $layout);
-		});
+		return $this->handleError(fn() => $this->service->create($title, $emoji, $this->getTable($tableId, true), null, layout: $layout));
 	}
 
 	#[NoAdminRequired]

src/modules/modals/ViewSettings.vue

@@ -268,7 +268,7 @@ export default {
 			},
 			set(value) {
 				this.ensureMutableViewSettings()
-				this.$set(this.mutableView.viewSettings, 'cardBackgroundSource', value ?? null)
+				this.mutableView.viewSettings.cardBackgroundSource = value ?? null
 			},
 		},
 		titleSourceValue: {
@@ -277,7 +277,7 @@ export default {
 			},
 			set(value) {
 				this.ensureMutableViewSettings()
-				this.$set(this.mutableView.viewSettings, 'cardTitleSource', value ?? null)
+				this.mutableView.viewSettings.cardTitleSource = value ?? null
 			},
 		},
 		saveText() {
@@ -495,8 +495,8 @@ export default {
 			const secondColumnId = this.mutableView.columnSettings?.[1]?.columnId ?? firstColumnId
 			const backgroundSource = this.mutableView.viewSettings.cardBackgroundSource ?? this.viewSetting?.viewSettings?.cardBackgroundSource ?? firstColumnId
 			const titleSource = this.mutableView.viewSettings.cardTitleSource ?? this.viewSetting?.viewSettings?.cardTitleSource ?? secondColumnId
-			this.$set(this.mutableView.viewSettings, 'cardBackgroundSource', backgroundSource)
-			this.$set(this.mutableView.viewSettings, 'cardTitleSource', titleSource)
+			this.mutableView.viewSettings.cardBackgroundSource = backgroundSource
+			this.mutableView.viewSettings.cardTitleSource = titleSource
 			this.errorTitle = false
 			this.selectedColumns = this.mutableView.columnSettings ? this.mutableView.columnSettings.map(item => item.columnId) : null
 			this.allColumns = []
@@ -505,10 +505,10 @@ export default {
 		},
 		ensureMutableViewSettings() {
 			if (!this.mutableView.viewSettings) {
-				this.$set(this.mutableView, 'viewSettings', {
+				this.mutableView.viewSettings = {
 					cardBackgroundSource: null,
 					cardTitleSource: null,
-				})
+				}
 			}
 		},
 		resolveCardSourceValue(stored, fallbackIndex) {
@@ -521,8 +521,8 @@ export default {
 		},
 		persistCardSourceFallbacks() {
 			this.ensureMutableViewSettings()
-			this.$set(this.mutableView.viewSettings, 'cardBackgroundSource', this.resolveCardSourceValue(this.mutableView.viewSettings.cardBackgroundSource, 0))
-			this.$set(this.mutableView.viewSettings, 'cardTitleSource', this.resolveCardSourceValue(this.mutableView.viewSettings.cardTitleSource, 1))
+			this.mutableView.viewSettings.cardBackgroundSource = this.resolveCardSourceValue(this.mutableView.viewSettings.cardBackgroundSource, 0)
+			this.mutableView.viewSettings.cardTitleSource = this.resolveCardSourceValue(this.mutableView.viewSettings.cardTitleSource, 1)
 		},
 		loadEmoji() {
 			const emojis = ['😀', '😃', '😄', '😁', '😆', '😅', '🤣', '😂', '🙂', '🙃', '🫠', '😉', '😊', '😇']

src/pages/Context.vue

@@ -22,15 +22,15 @@
 			<div class="resources">
 				<div v-for="resource in contextResources" :key="resource.key">
 					<div v-if="!resource.isView" class="resource">
-						<TableWrapper :table="resource" :columns="columns[resource.key]" :rows="rows[resource.key]"
-							:view-setting.sync="resourceViewSettings[resource.key]" @create-column="createColumn(false, resource)"
+						<TableWrapper v-model:view-setting="resourceViewSettings[resource.key]" :table="resource" :columns="columns[resource.key]"
+							:rows="rows[resource.key]" @create-column="createColumn(false, resource)"
 							@import-scheme="openImportSchemeModal(resource)"
 							@import="openImportModal(resource, false)" @download-csv="downloadCSV(resource, false)"
 							@download-filtered-csv="rows => downloadFilteredCSV(rows, resource, false)" />
 					</div>
 					<div v-else-if="resource.isView" class="resource">
-						<CustomView :view="resource" :columns="columns[resource.key]" :rows="rows[resource.key]"
-							:view-setting.sync="resourceViewSettings[resource.key]" @create-column="createColumn(true, resource)"
+						<CustomView v-model:view-setting="resourceViewSettings[resource.key]" :view="resource" :columns="columns[resource.key]"
+							:rows="rows[resource.key]" @create-column="createColumn(true, resource)"
 							@import="openImportModal(resource, true)" @download-csv="downloadCSV(resource, true)"
 							@download-filtered-csv="rows => downloadFilteredCSV(rows, resource, true)" />
 					</div>
@@ -221,7 +221,7 @@ export default {
 										})
 										table.key = (table.id).toString()
 										table.isView = false
-										this.$set(this.resourceViewSettings, table.key, this.createViewSetting(false, table))
+										this.resourceViewSettings[table.key] = this.createViewSetting(false, table)
 										this.contextResources.push(table)
 									}
 
@@ -238,7 +238,7 @@ export default {
 										})
 										view.key = 'view-' + (view.id).toString()
 										view.isView = true
-										this.$set(this.resourceViewSettings, view.key, this.createViewSetting(true, view))
+										this.resourceViewSettings[view.key] = this.createViewSetting(true, view)
 										this.contextResources.push(view)
 									}
 								}

tests/unit/TablesMigratorTest.php

@@ -322,14 +322,12 @@ public function testImportRemapsViewCardSources(): void {
 			],
 		];
 
-		$importSource->method('getFileContents')->willReturnCallback(static function (string $file) use ($tableData, $columns, $views): string {
-			return match ($file) {
+		$importSource->method('getFileContents')->willReturnCallback(static fn(string $file): string => match ($file) {
 				'tables.json' => json_encode([$tableData]),
 				'columns.json' => json_encode($columns),
 				'views.json' => json_encode($views),
 				default => json_encode([]),
-			};
-		});
+			});
 
 		$newTable = new Table();
 		$newTable->setId(100);