cleanup and pipelines fix

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>

Author: Koc

REUSE.toml

@@ -29,12 +29,6 @@ precedence = "aggregate"
 SPDX-FileCopyrightText = "2025 Nextcloud GmbH and Nextcloud contributors"
 SPDX-License-Identifier = "AGPL-3.0-or-later"
 
-[[annotations]]
-path = ["vendor-bin/rector/composer.json", "vendor-bin/rector/composer.lock"]
-precedence = "aggregate"
-SPDX-FileCopyrightText = "2025 Nextcloud GmbH and Nextcloud contributors"
-SPDX-License-Identifier = "AGPL-3.0-or-later"
-
 [[annotations]]
 path = ["img/app-dark.svg", "img/app.svg", "img/view.svg", "img/view-dark.svg", "img/material/*.svg"]
 precedence = "aggregate"

lib/Activity/ChangeSet.php

@@ -24,11 +24,11 @@ public function __construct(
 		}
 	}
 
-	public function setBefore(Entity $before) {
+	public function setBefore($before) {
 		$this->before = clone $before;
 	}
 
-	public function setAfter(Entity $after) {
+	public function setAfter($after) {
 		$this->after = clone $after;
 	}
 

lib/Analytics/AnalyticsDatasource.php

@@ -338,7 +338,7 @@ private function formatBooleanValue(mixed $value): string {
 		return '';
 	}
 
-	private function formatTextValue(Column $column, string $value): string {
+	private function formatTextValue(Column $column, mixed $value): string {
 		if ($value === null || $value === '') {
 			return '';
 		}

lib/Controller/PublicRowOCSController.php

@@ -54,6 +54,10 @@ public function __construct(
 	 * @param string $token The share token
 	 * @param int|null $limit Optional: maximum number of results, capped at 500
 	 * @param int|null $offset Optional: the offset for this operation
+	 * @param string|null $filter Optional: a JSON encoded filter parameter
+	 * @param string|null $sort Optional: a JSON encoded sort parameter
+	 * @param string|null $search Optional: a search string
+	 * @param string|null $rowIds Optional: a JSON encoded list of row IDs
 	 * @return DataResponse<Http::STATUS_OK, list<TablesPublicRow>, array{}>|DataResponse<Http::STATUS_FORBIDDEN|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND|Http::STATUS_INTERNAL_SERVER_ERROR, array{message: string}, array{}>
 	 *
 	 * 200: Rows are returned
@@ -164,7 +168,7 @@ public function countRows(string $token, ?string $filter = null, ?string $sort =
 	 * @param ?string $sort Optional: a JSON encoded sort parameter
 	 * @param ?string $search Optional: a search string
 	 * @param ?string $rowIds Optional: a JSON encoded list of row IDs to export
-	 * @return DataDownloadResponse<Http::STATUS_OK, array{headers: array<string, string>}>|DataResponse<Http::STATUS_FORBIDDEN|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND|Http::STATUS_INTERNAL_SERVER_ERROR, array{message: string}, array{}>
+	 * @return DataDownloadResponse<Http::STATUS_OK, 'text/csv', array{}>|DataResponse<Http::STATUS_FORBIDDEN|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND|Http::STATUS_INTERNAL_SERVER_ERROR, array{message: string}, array{}>
 	 *
 	 * 200: CSV file is returned
 	 * 400: Invalid request parameters

lib/Controller/RowOCSController.php

@@ -125,6 +125,8 @@ public function createRow(string $nodeCollection, int $nodeId, mixed $data): Dat
 	 * @psalm-param ?int<0,max> $offset Offset of the rows to be returned (optional)
 	 * @param ?string $filter JSON encoded list of filter groups. Definitions within a group are AND-connected, groups are OR-connected, e.g. `[[{"columnId":1,"operator":"contains","value":"foo"}]]` (optional)
 	 * @param ?string $sort JSON encoded list of sort rules, e.g. `[{"columnId":1,"mode":"ASC"}]` (optional)
+	 * @param ?string $search Search string (optional)
+	 * @param ?string $rowIds JSON encoded list of row IDs (optional)
 	 * @return DataResponse<Http::STATUS_OK, list<TablesRow>, array{}>|DataResponse<Http::STATUS_FORBIDDEN|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND|Http::STATUS_INTERNAL_SERVER_ERROR, array{message: string}, array{}>
 	 *
 	 * 200: Rows returned
@@ -171,6 +173,22 @@ public function getRows(string $nodeCollection, int $nodeId, ?int $limit = null,
 		}
 	}
 
+	/**
+	 * [api v2] Count rows from a table or view
+	 *
+	 * @param 'tables'|'views' $nodeCollection Indicates whether to read from a table or a view
+	 * @psalm-param int<0,max> $nodeId The ID of the table or view
+	 * @param string|null $filter Optional: a JSON encoded filter parameter
+	 * @param string|null $sort Optional: a JSON encoded sort parameter
+	 * @param string|null $search Optional: a search string
+	 * @return DataResponse<Http::STATUS_OK, array{count: int}, array{}>|DataResponse<Http::STATUS_FORBIDDEN|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND|Http::STATUS_INTERNAL_SERVER_ERROR, array{message: string}, array{}>
+	 *
+	 * 200: Count is returned
+	 * 400: Invalid request parameters
+	 * 403: No permissions
+	 * 404: Not found
+	 * 500: Internal error
+	 */
 	#[NoAdminRequired]
 	#[RequirePermission(permission: Application::PERMISSION_READ, typeParam: 'nodeCollection')]
 	#[ApiRoute(
@@ -209,7 +227,7 @@ public function countRows(string $nodeCollection, int $nodeId, ?string $filter =
 	 * @param ?string $sort JSON encoded list of sort rules (optional)
 	 * @param ?string $search Search string (optional)
 	 * @param ?string $rowIds JSON encoded list of row IDs to export (optional)
-	 * @return DataDownloadResponse<Http::STATUS_OK, array{headers: array<string, string>}>|DataResponse<Http::STATUS_FORBIDDEN|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND|Http::STATUS_INTERNAL_SERVER_ERROR, array{message: string}, array{}>
+	 * @return DataDownloadResponse<Http::STATUS_OK, 'text/csv', array{}>|DataResponse<Http::STATUS_FORBIDDEN|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND|Http::STATUS_INTERNAL_SERVER_ERROR, array{message: string}, array{}>
 	 *
 	 * 200: CSV file is returned
 	 * 400: Invalid request parameters

lib/Service/ImportService.php

@@ -701,7 +701,7 @@ private function upsertRow(Row $row, array $columnBusinesses): void {
 	/**
 	 * @param null|string $value
 	 */
-	private function valueToDateTimeImmutable(string|null $value): ?DateTimeImmutable {
+	private function valueToDateTimeImmutable(?string $value): ?DateTimeImmutable {
 		if (
 			$value === false
 			|| $value === null