fix(sharereview): log warnings for unknown node and receiver types of shares

Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Author: AndyScherzinger

lib/ShareReview/ShareReviewSource.php

@@ -192,22 +192,41 @@ private function fetchNames(string $table, string $nameColumn, array $ids): arra
 	 */
 	private function resolveObjectName(array $share, array $tableNames, array $viewNames, array $contextNames): string {
 		$nodeId = (int)$share['node_id'];
-		return match($share['node_type']) {
-			self::NODE_TYPE_TABLE => $this->l10n->t('%s (Table)', [$tableNames[$nodeId] ?? $this->l10n->t('Table %s', [$nodeId])]),
-			self::NODE_TYPE_VIEW => $this->l10n->t('%s (View)', [$viewNames[$nodeId] ?? $this->l10n->t('View %s', [$nodeId])]),
-			self::NODE_TYPE_CONTEXT => $this->l10n->t('%s (Context)', [$contextNames[$nodeId] ?? $this->l10n->t('Context %s', [$nodeId])]),
-			default => $this->l10n->t('Unknown %s', [$nodeId]),
-		};
+		$nodeType = (string)$share['node_type'];
+		if ($nodeType === self::NODE_TYPE_TABLE) {
+			return $this->l10n->t('%s (Table)', [$tableNames[$nodeId] ?? $this->l10n->t('Table %s', [$nodeId])]);
+		}
+		if ($nodeType === self::NODE_TYPE_VIEW) {
+			return $this->l10n->t('%s (View)', [$viewNames[$nodeId] ?? $this->l10n->t('View %s', [$nodeId])]);
+		}
+		if ($nodeType === self::NODE_TYPE_CONTEXT) {
+			return $this->l10n->t('%s (Context)', [$contextNames[$nodeId] ?? $this->l10n->t('Context %s', [$nodeId])]);
+		}
+		$this->logger->warning(
+			'Tables ShareReview: unknown node type {type} for share node {id}',
+			['type' => $nodeType, 'id' => $nodeId]
+		);
+		return $this->l10n->t('Unknown %s', [$nodeId]);
 	}
 
 	private function mapReceiverType(string $receiverType): int {
-		return match($receiverType) {
-			'user' => IShare::TYPE_USER,
-			'group' => IShare::TYPE_GROUP,
-			'link' => IShare::TYPE_LINK,
-			'circle' => IShare::TYPE_CIRCLE,
-			default => IShare::TYPE_USER,
-		};
+		if ($receiverType === 'user') {
+			return IShare::TYPE_USER;
+		}
+		if ($receiverType === 'group') {
+			return IShare::TYPE_GROUP;
+		}
+		if ($receiverType === 'link') {
+			return IShare::TYPE_LINK;
+		}
+		if ($receiverType === 'circle') {
+			return IShare::TYPE_CIRCLE;
+		}
+		$this->logger->warning(
+			'Tables ShareReview: unknown receiver type {type}, falling back to user share type',
+			['type' => $receiverType]
+		);
+		return IShare::TYPE_USER;
 	}
 
 	/** @param array<string, mixed> $share */

tests/unit/ShareReview/ShareReviewSourceTest.php

@@ -199,6 +199,31 @@ public function testGetSharesDeletedNode(): void {
 		$this->assertSame('Table 42 (Table)', $shares[0]['object']);
 	}
 
+	public function testGetSharesUnknownNodeTypeLogsWarning(): void {
+		$this->db->method('getQueryBuilder')->willReturnOnConsecutiveCalls(
+			$this->makeQb([$this->makeShareRow(['node_type' => 'dashboard', 'node_id' => 5])]),
+		);
+		$this->logger->expects($this->once())->method('warning');
+
+		$shares = $this->source->getShares();
+
+		$this->assertCount(1, $shares);
+		$this->assertSame('Unknown 5', $shares[0]['object']);
+	}
+
+	public function testGetSharesUnknownReceiverTypeLogsWarning(): void {
+		$this->db->method('getQueryBuilder')->willReturnOnConsecutiveCalls(
+			$this->makeQb([$this->makeShareRow(['receiver_type' => 'email', 'receiver' => 'bob@example.com'])]),
+			$this->makeQb([['id' => 10, 'title' => 'My Table']]),
+		);
+		$this->logger->expects($this->once())->method('warning');
+
+		$shares = $this->source->getShares();
+
+		$this->assertCount(1, $shares);
+		$this->assertSame(IShare::TYPE_USER, $shares[0]['type']);
+	}
+
 	public function testGetSharesReturnsEmptyOnDbException(): void {
 		$this->db->method('getQueryBuilder')->willReturn($this->makeThrowingQb());
 		$this->logger->expects($this->once())->method('error');