fix(RowService): allow public share row operations without breaking async import guard

ef3db38 tightened the userId guard in RowService::create() and ::updateSet()
from `=== null` to `=== null || === ''` to prevent async import background jobs
from silently creating rows without a real user in context.

However, the codebase intentionally uses an empty string as the public-context
sentinel: PublicRowOCSController calls setPublicContext(), which sets
$this->userId = '' in SuperService and $isPublicContext = true in
PermissionsService. PermissionsService::basisCheck() explicitly handles
$userId === '' by returning true when isPublicContext is set. The tightened
guard in ef3db38 rejected '' before it ever reached the permissions layer,
breaking row create and update for all public link shares.

The fix tracks the public context flag in SuperService itself via a new
$isPublicContext property, set alongside $this->userId = '' in
setPublicContext(). The guard in RowService is updated to:

  null              → always throws (DI never injected a user)
  '' + !publicCtx   → throws (background job running without a user — the
                       case ef3db38 was protecting against)
  '' + publicCtx    → passes (setPublicContext() was called intentionally)
  'alice'           → always passes (normal authenticated user)

Async imports remain protected because ImportTableJob never calls
setPublicContext(), so $isPublicContext stays false for that code path.

AI-assistant: Claude Code v2.1.143 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Author: AndyScherzinger

lib/Service/RowService.php

@@ -182,7 +182,7 @@ public function create(?int $tableId, ?int $viewId, RowDataInput|array $data, ?s
 		if ($userId) {
 			$this->userId = $userId;
 		}
-		if ($this->userId === null || $this->userId === '') {
+		if ($this->userId === null || ($this->userId === '' && !$this->isPublicContext)) {
 			$e = new \Exception('No user id in context, but needed.');
 			$this->logger->error($e->getMessage(), ['exception' => $e]);
 			throw new InternalError(get_class($this) . ' - ' . __FUNCTION__ . ': ' . $e->getMessage());
@@ -571,7 +571,7 @@ public function updateSet(
 		if ($userId) {
 			$this->userId = $userId;
 		}
-		if ($this->userId === null || $this->userId === '') {
+		if ($this->userId === null || ($this->userId === '' && !$this->isPublicContext)) {
 			$e = new \Exception('No user id in context, but needed.');
 			$this->logger->error($e->getMessage(), ['exception' => $e]);
 			throw new InternalError(get_class($this) . ' - ' . __FUNCTION__ . ': ' . $e->getMessage());

lib/Service/SuperService.php

@@ -16,6 +16,8 @@ class SuperService {
 
 	protected ?string $userId;
 
+	protected bool $isPublicContext = false;
+
 	public function __construct(LoggerInterface $logger, ?string $userId, PermissionsService $permissionsService) {
 		$this->permissionsService = $permissionsService;
 		$this->logger = $logger;
@@ -24,6 +26,7 @@ public function __construct(LoggerInterface $logger, ?string $userId, Permission
 
 	public function setPublicContext(): void {
 		$this->userId = '';
+		$this->isPublicContext = true;
 		$this->permissionsService->setPublicContext();
 	}
 }