Shares in federated conversation broken for public conversations

[SystemKeeper]

Tip

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. Instance A: Have a conversation that is public (!)
2. Instance A: Post a picture
3. Instance A: Invite participant from instance B
4. Instance B: Accept invite and open conversation

Expected behaviour

Actual behaviour

From what I can see it's a regression from conversation folders, namely bb1a36d.

spreed/lib/Chat/Parser/SystemMessage.php

Lines 544 to 550 in c22c371

	if (isset($parameters['share'])) {
	$parsedParameters['file'] = $this->getFileFromShare($room, $participant, $parameters['share'], $allowInaccurate);
	} elseif (isset($parameters['fileId'])) {
	$parsedParameters['file'] = $this->getFileFromNodeId($room, $participant, (int)$parameters['fileId'], $allowInaccurate);
	} else {
	throw new \InvalidArgumentException('No share or fileId in file_shared message');
	}

Since this is not throwing anymore, we don't end up at

spreed/lib/Chat/Parser/SystemMessage.php

Lines 575 to 577 in c22c371

	} elseif ($currentActorType === Attendee::ACTOR_FEDERATED_USERS) {
	$parsedMessage = $this->l->t('File shares are currently not supported in federated conversations');
	}

Talk app

Talk app version: Tested stable34 -> main