Merge pull request #19025 from nextcloud/fix/13777/temp-messages-timestamp

fix: use real timestamp for temp messages

Author: Antreesy

src/components/Dashboard/TalkDashboard.vue

@@ -36,6 +36,7 @@ import { EventBus } from '../../services/EventBus.ts'
 import { useActorStore } from '../../stores/actor.ts'
 import { useDashboardStore } from '../../stores/dashboard.ts'
 import { hasUnreadMentions } from '../../utils/conversation.ts'
+import { convertToUnix } from '../../utils/formattedTime.ts'
 import { copyConversationLinkToClipboard } from '../../utils/handleUrl.ts'
 
 const supportsUpcomingReminders = hasTalkFeature('local', 'upcoming-reminders')
@@ -154,7 +155,7 @@ async function startMeeting() {
 			roomName: conversationName.value || t('spreed', 'Meeting'),
 			roomType: CONVERSATION.TYPE.PUBLIC,
 			objectType: CONVERSATION.OBJECT_TYPE.INSTANT_MEETING,
-			objectId: Math.floor(Date.now() / 1000).toString(),
+			objectId: convertToUnix(new Date()).toString(),
 		})
 		await copyConversationLinkToClipboard(conversation.token)
 		await router.push({

src/components/LeftSidebar/ConversationsList/Conversation.spec.js

@@ -17,6 +17,7 @@ import { ATTENDEE, CONVERSATION, MESSAGE, PARTICIPANT } from '../../../constants
 import { leaveConversation } from '../../../services/participantsService.js'
 import storeConfig from '../../../store/storeConfig.js'
 import { findNcActionButton } from '../../../test-helpers.js'
+import { convertToUnix } from '../../../utils/formattedTime.ts'
 
 vi.mock('../../../services/participantsService', () => ({
 	leaveConversation: vi.fn(),
@@ -237,8 +238,8 @@ describe('ConversationItem.vue', () => {
 		it.each(TEST_CASES)(
 			'should render correct timestamp for %s',
 			(message, activity, output) => {
-				item.lastMessage.timestamp = message && new Date(message).valueOf() / 1000
-				item.lastActivity = activity && new Date(activity).valueOf() / 1000
+				item.lastMessage.timestamp = message && convertToUnix(new Date(message))
+				item.lastActivity = activity && convertToUnix(new Date(activity))
 
 				const wrapper = mountConversation(false)
 

src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.spec.js

@@ -18,6 +18,7 @@ import { useActorStore } from '../../../../../stores/actor.ts'
 import { useIntegrationsStore } from '../../../../../stores/integrations.js'
 import { useTokenStore } from '../../../../../stores/token.ts'
 import { findNcActionButton, findNcButton } from '../../../../../test-helpers.js'
+import { convertToUnix } from '../../../../../utils/formattedTime.ts'
 
 describe('MessageButtonsBar.vue', () => {
 	const TOKEN = 'XXTOKENXX'
@@ -65,7 +66,7 @@ describe('MessageButtonsBar.vue', () => {
 				messageParameters: {},
 				id: 123,
 				isReplyable: true,
-				timestamp: new Date('2020-05-07 09:23:00').getTime() / 1000,
+				timestamp: convertToUnix(new Date('2020-05-07 09:23:00')),
 				token: TOKEN,
 				systemMessage: '',
 				messageType: MESSAGE.TYPE.COMMENT,

src/components/MessagesList/MessagesGroup/Message/MessageItem.spec.js

@@ -32,6 +32,7 @@ import { EventBus } from '../../../../services/EventBus.ts'
 import storeConfig from '../../../../store/storeConfig.js'
 import { useActorStore } from '../../../../stores/actor.ts'
 import { useTokenStore } from '../../../../stores/token.ts'
+import { convertToUnix } from '../../../../utils/formattedTime.ts'
 
 let store
 
@@ -94,7 +95,7 @@ describe('MessageItem.vue', () => {
 				messageParameters: {},
 				id: 123,
 				isReplyable: true,
-				timestamp: new Date('2020-05-07 09:23:00').getTime() / 1000,
+				timestamp: convertToUnix(new Date('2020-05-07 09:23:00')),
 				token: TOKEN,
 				systemMessage: '',
 				messageType: MESSAGE.TYPE.COMMENT,
@@ -533,7 +534,7 @@ describe('MessageItem.vue', () => {
 		})
 
 		test('does not render actions for temporary messages', async () => {
-			messageProps.message.timestamp = 0
+			messageProps.message.id = 'temp-123'
 
 			const wrapper = mountMessage(messageProps)
 
@@ -644,7 +645,7 @@ describe('MessageItem.vue', () => {
 		})
 
 		test('displays the message already with a spinner while sending it', () => {
-			messageProps.message.timestamp = 0
+			messageProps.message.id = 'temp-123'
 			const wrapper = mountMessage(messageProps)
 			const message = wrapper.findComponent(NcRichText)
 			expect(message.text()).toBe('test message')

src/components/MessagesList/MessagesGroup/Message/MessageItem.vue

@@ -113,7 +113,7 @@ import { hasTalkFeature } from '../../../../services/CapabilitiesManager.ts'
 import { EventBus } from '../../../../services/EventBus.ts'
 import { useActorStore } from '../../../../stores/actor.ts'
 import { useChatExtrasStore } from '../../../../stores/chatExtras.ts'
-import { isFilePreviewParameter } from '../../../../utils/message.ts'
+import { isFilePreviewParameter, isTemporaryId } from '../../../../utils/message.ts'
 
 const LocationCard = defineAsyncComponent(() => import('./MessagePart/LocationCard.vue'))
 
@@ -187,7 +187,7 @@ export default {
 		},
 
 		isTemporary() {
-			return !this.isScheduledMessage && this.message.timestamp === 0
+			return !this.isScheduledMessage && isTemporaryId(this.message.id)
 		},
 
 		isDeletedMessage() {
@@ -319,7 +319,7 @@ export default {
 			}
 
 			return this.message.id === this.message.threadId
-				|| this.message.id.toString().startsWith('temp-')
+				|| isTemporaryId(this.message.id)
 				|| (this.isScheduledMessage && this.message.threadId === -1)
 		},
 

src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue

@@ -222,7 +222,12 @@ import { useChatExtrasStore } from '../../../../../stores/chatExtras.ts'
 import { usePollsStore } from '../../../../../stores/polls.ts'
 import { useUploadStore } from '../../../../../stores/upload.ts'
 import { formatDateTime } from '../../../../../utils/formattedTime.ts'
-import { getFileKeys, getFilePreviewKeys, isFilePreviewParameter } from '../../../../../utils/message.ts'
+import {
+	getFileKeys,
+	getFilePreviewKeys,
+	isFilePreviewParameter,
+	isTemporaryId,
+} from '../../../../../utils/message.ts'
 import { parseMentions, parseSpecialSymbols } from '../../../../../utils/textParse.ts'
 
 // Regular expression to check for Unicode emojis in message text
@@ -433,7 +438,7 @@ export default {
 		},
 
 		isTemporary() {
-			return !this.isScheduledMessage && this.message.timestamp === 0
+			return !this.isScheduledMessage && isTemporaryId(this.message.id)
 		},
 
 		isScheduledSendingFailure() {

src/components/MessagesList/MessagesList.spec.js

@@ -18,6 +18,7 @@ import router from '../../__mocks__/router.js'
 import { ATTENDEE, MESSAGE } from '../../constants.ts'
 import storeConfig from '../../store/storeConfig.js'
 import { useChatStore } from '../../stores/chat.ts'
+import { convertToUnix } from '../../utils/formattedTime.ts'
 
 vi.mock('vuex', async () => {
 	const vuex = await vi.importActual('vuex')
@@ -48,7 +49,7 @@ vi.mock('../../composables/useGetMessages.ts', async () => ({
 	})),
 }))
 
-const fakeTimestamp = (value) => new Date(value).getTime() / 1000
+const fakeTimestamp = (value) => convertToUnix(new Date(value))
 
 describe('MessagesList.vue', () => {
 	const TOKEN = 'XXTOKENXX'

src/components/MessagesList/MessagesList.vue

@@ -476,7 +476,7 @@ export default {
 				if (!this.messagesShouldBeGrouped(message, lastMessage)) {
 					groupId = message.id
 					if (message.timestamp === 0) {
-						// This is a temporary message, the timestamp is today
+						// This is a scheduled message that failed to send, the timestamp is today
 						dateTimestamp = this.currentDay
 					} else {
 						dateTimestamp = convertToUnix(new Date(message.timestamp * 1000).setHours(0, 0, 0, 0))
@@ -635,9 +635,6 @@ export default {
 		 * @return {object} Date object
 		 */
 		getDateOfMessage(message) {
-			if (message.id.toString().startsWith('temp-')) {
-				return new Date()
-			}
 			return new Date(message.timestamp * 1000)
 		},
 

src/composables/__tests__/useMessageInfo.spec.js

@@ -10,6 +10,7 @@ import { useStore } from 'vuex'
 import { ATTENDEE, CONVERSATION, MESSAGE } from '../../constants.ts'
 import { useActorStore } from '../../stores/actor.ts'
 import { useGuestNameStore } from '../../stores/guestName.ts'
+import { convertToUnix } from '../../utils/formattedTime.ts'
 import { useConversationInfo } from '../useConversationInfo.ts'
 import { useMessageInfo } from '../useMessageInfo.ts'
 
@@ -49,7 +50,7 @@ describe('message actions', () => {
 			messageParameters: {},
 			id: 123,
 			isReplyable: true,
-			timestamp: new Date('2024-05-01 16:15:00').getTime() / 1000,
+			timestamp: convertToUnix(new Date('2024-05-01 16:15:00')),
 			token: TOKEN,
 			systemMessage: '',
 			messageType: MESSAGE.TYPE.COMMENT,
@@ -78,7 +79,7 @@ describe('message actions', () => {
 
 	test('message is not deleteable when it is older than 6 hours and unlimited capability is disabled', () => {
 		// Arrange
-		message.value.timestamp = new Date('2024-05-01 7:20:00').getTime() / 1000
+		message.value.timestamp = convertToUnix(new Date('2024-05-01 7:20:00'))
 		// Act
 		const result = useMessageInfo(message)
 		// Assert
@@ -173,7 +174,7 @@ describe('message actions', () => {
 
 	test('can edit own message in note to self', () => {
 		// Arrange
-		message.value.timestamp = new Date('2024-04-28 7:20:00').getTime() / 1000
+		message.value.timestamp = convertToUnix(new Date('2024-04-28 7:20:00'))
 		conversationProps.type = CONVERSATION.TYPE.NOTE_TO_SELF
 		// Act
 		const result = useMessageInfo(message)
@@ -368,11 +369,11 @@ describe('message actions', () => {
 				messageParameters: {},
 				id: 123,
 				isReplyable: true,
-				lastEditTimestamp: new Date('2024-05-01 16:30:00').getTime() / 1000,
+				lastEditTimestamp: convertToUnix(new Date('2024-05-01 16:30:00')),
 				lastEditActorId: 'user-id-1',
 				lastEditActorType: ATTENDEE.ACTOR_TYPE.USERS,
 				lastEditActorDisplayName: 'user-display-name-1',
-				timestamp: new Date('2024-05-01 16:15:00').getTime() / 1000,
+				timestamp: convertToUnix(new Date('2024-05-01 16:15:00')),
 				token: TOKEN,
 				systemMessage: '',
 				messageType: MESSAGE.TYPE.COMMENT,

src/store/conversationsStore.spec.js

@@ -40,6 +40,7 @@ import { setConversationUnread, updateLastReadMessage } from '../services/messag
 import { useActorStore } from '../stores/actor.ts'
 import { useTalkHashStore } from '../stores/talkHash.js'
 import { generateOCSErrorResponse, generateOCSResponse } from '../test-helpers.js'
+import { convertToUnix } from '../utils/formattedTime.ts'
 import storeConfig from './storeConfig.js'
 
 vi.mock('../services/conversationsService', () => ({
@@ -1022,7 +1023,7 @@ describe('conversationsStore', () => {
 			vi.useRealTimers()
 
 			const changedConversation = store.getters.conversation(testToken)
-			expect(changedConversation.lastActivity).toBe(mockDate.getTime() / 1000)
+			expect(changedConversation.lastActivity).toBe(convertToUnix(mockDate))
 		})
 	})