Skip to content

Commit 1ba676a

Browse files
Rikdekkerclaude
andcommitted
fix: Address remaining CI failures (psalm type hint, AttendeeMapper warning)
- Add psalm type annotation for json_decode result in ConversationCategoryMapper - Handle missing category_ids key in AttendeeMapper::createAttendeeFromRow Signed-off-by: Rikdekker <Rikdekker@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 68197b7 commit 1ba676a

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

lib/Model/AttendeeMapper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ public function createAttendeeFromRow(array $row): Attendee {
311311
'archived' => (bool)$row['archived'],
312312
'important' => (bool)$row['important'],
313313
'sensitive' => (bool)$row['sensitive'],
314-
'category_ids' => $row['category_ids'],
314+
'category_ids' => $row['category_ids'] ?? null,
315315
'has_unread_threads' => (bool)$row['has_unread_threads'],
316316
'has_unread_thread_mentions' => (bool)$row['has_unread_thread_mentions'],
317317
'has_unread_thread_directs' => (bool)$row['has_unread_thread_directs'],

lib/Model/ConversationCategoryMapper.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public function clearCategoryFromAttendees(int|string $categoryId, string $userI
7373

7474
$result = $qb->executeQuery();
7575
while ($row = $result->fetch()) {
76+
/** @var list<string|int> $categoryIds */
7677
$categoryIds = json_decode($row['category_ids'], true) ?? [];
7778
$categoryIds = array_values(array_filter($categoryIds, fn ($id) => (string)$id !== $categoryIdStr));
7879

0 commit comments

Comments
 (0)