chore(rector): Apply nextcloud 30 set

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>

Author: Carl Schwan

lib/Controller/ApiController.php

@@ -30,39 +30,20 @@
 use OCP\AppFramework\OCS\OCSNotFoundException;
 use OCP\AppFramework\OCSController;
 use OCP\IRequest;
-use OCP\IUserManager;
 use OCP\IUserSession;
 use OCP\Share\IShare;
 use function iter\filter;
 use function iter\map;
 use function iter\toArray;
 
 class ApiController extends OCSController {
-
-	/** @var IUserSession */
-	protected $userSession;
-
-	/** @var SharesList */
-	protected $sharesList;
-
-	/**
-	 * @param string $appName
-	 * @param IRequest $request
-	 * @param IUserSession $userSession
-	 * @param IUserManager $userManager
-	 * @param SharesList $sharesList
-	 */
 	public function __construct(
 		string $appName,
 		IRequest $request,
-		IUserSession $userSession,
-		private IUserManager $userManager,
-		SharesList $sharesList,
+		private IUserSession $userSession,
+		private SharesList $sharesList,
 	) {
 		parent::__construct($appName, $request);
-
-		$this->userSession = $userSession;
-		$this->sharesList = $sharesList;
 	}
 
 	/**
@@ -71,7 +52,6 @@ public function __construct(
 	 * Get shared sub folders of a fiven path
 	 *
 	 * @param string $path path of the current folder
-	 * @return DataResponse
 	 */
 	public function getSharedSubfolders(string $path): DataResponse {
 		$currentUser = $this->userSession->getUser();

rector.php

@@ -5,6 +5,7 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
+use Nextcloud\Rector\Set\NextcloudSets;
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\StaticCall\RemoveParentCallWithoutParentRector;
 use Rector\Set\ValueObject\SetList;
@@ -24,6 +25,7 @@
 		SetList::PHP_74,
 		SetList::PHP_80,
 		SetList::PHP_81,
+		NextcloudSets::NEXTCLOUD_30,
 	]);
 	$rectorConfig->rule(ReturnTypeFromStrictTypedPropertyRector::class);
 	$rectorConfig->rule(ReturnUnionTypeRector::class);

tests/bootstrap.php

@@ -1,12 +1,17 @@
 <?php
 
-define('PHPUNIT_RUN', 1);
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
 
-require_once __DIR__ . '/../../../lib/base.php';
+declare(strict_types=1);
 
-OC::$composerAutoloader->addPsr4('Test\\', OC::$SERVERROOT . '/tests/lib/', true);
-OC::$composerAutoloader->addPsr4('Tests\\', OC::$SERVERROOT . '/tests/', true);
+use OCP\App\IAppManager;
+use OCP\Server;
 
-OC_App::loadApp('sharelisting');
+require_once __DIR__ . '/../../../lib/base.php';
+require_once __DIR__ . '/../../../tests/autoload.php';
+require_once __DIR__ . '/../vendor/autoload.php';
 
-OC_Hook::clear();
+Server::get(IAppManager::class)->loadApp('approval');