fix: clear key password after loading key

Signed-off-by: Robin Appelman <robin@icewind.nl>

# Conflicts:
#	apps/files_external/lib/Lib/Auth/PublicKey/RSA.php

# Conflicts:
#	apps/files_external/lib/Lib/Auth/PublicKey/RSA.php
#	apps/files_external/lib/Lib/Auth/PublicKey/RSAPrivateKey.php

Author: icewind1991

apps/files_external/lib/Lib/Auth/PublicKey/RSA.php

@@ -59,6 +59,7 @@ public function manipulateStorageConfig(StorageConfig &$storage, ?IUser $user =
 		if (!$auth instanceof RSACrypt\PrivateKey) {
 			throw new \RuntimeException('Loaded key is not a private key');
 		}
+		$auth = $auth->withPassword('');
 		$storage->setBackendOption('public_key_auth', $auth);
 	}
 

apps/files_external/lib/Lib/Auth/PublicKey/RSAPrivateKey.php

@@ -61,6 +61,8 @@ public function manipulateStorageConfig(StorageConfig &$storage, ?IUser $user =
 		if (!$auth instanceof RSA\PrivateKey) {
 			throw new \RuntimeException('Loaded key is not a private key');
 		}
+
+		$auth = $auth->withPassword('');
 		$storage->setBackendOption('public_key_auth', $auth);
 	}
 }