Skip to content

Commit ee1044d

Browse files
committed
chore(core): remove assets for review
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
1 parent 922a3f8 commit ee1044d

8 files changed

Lines changed: 27 additions & 27 deletions

File tree

core/src/components/UnifiedSearch/SearchResult.vue

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,6 @@ export default {
157157

158158
<style lang="scss" scoped>
159159
.result-item {
160-
// Positioning context for the selection pill. NcListItem's wrapper already sets this;
161-
// repeated so the pseudo-element below does not depend on that.
162-
position: relative;
163160
padding-inline: 0;
164161
165162
:deep(a) {
@@ -187,22 +184,25 @@ export default {
187184
// NcListItem's `active` state paints a primary fill, white text and a blue stripe.
188185
// We want a neutral look: the gray hover fill plus a maxcontrast border, readable text.
189186
&.list-item__wrapper--active {
190-
// Keyboard selection marker: the pill the left navigation paints on its active entry.
191-
&::before {
192-
content: '';
193-
position: absolute;
194-
inset-block: calc(var(--default-grid-baseline) * 2);
195-
inset-inline-start: 0;
196-
width: 3px;
197-
border-radius: var(--border-radius-rounded);
198-
background-color: var(--color-primary-element);
199-
// Zeroed by the reduced-motion theme, so no separate media query is needed.
200-
animation: result-pill-in var(--animation-quick) ease-out;
201-
}
202-
203187
:deep(.list-item) {
204188
background-color: var(--color-background-hover);
205189
190+
// Keyboard selection marker: the pill the left navigation paints on its active
191+
// entry. It has to hang off .list-item rather than the wrapper, because
192+
// .list-item is itself positioned and paints the opaque row background, so it
193+
// would cover a pseudo-element belonging to its parent.
194+
&::before {
195+
content: '';
196+
position: absolute;
197+
inset-block: calc(var(--default-grid-baseline) * 2);
198+
inset-inline-start: 0;
199+
width: 3px;
200+
border-radius: var(--border-radius-rounded);
201+
background-color: var(--color-primary-element);
202+
// Zeroed by the reduced-motion theme, so no separate media query is needed.
203+
animation: result-pill-in var(--animation-quick) ease-out;
204+
}
205+
206206
&:hover {
207207
background-color: var(--color-background-hover);
208208
}

core/src/components/UnifiedSearch/UnifiedSearchModal.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1676,7 +1676,7 @@ export default defineComponent({
16761676
16771677
&__detail-title {
16781678
font-size: var(--default-font-size);
1679-
font-weight: bold;
1679+
font-weight: var(--font-weight-heading);
16801680
grid-column: 2;
16811681
margin: 0;
16821682
margin-block-start: -3px;
@@ -1766,7 +1766,7 @@ export default defineComponent({
17661766
}
17671767
17681768
&__unfiltered-label {
1769-
font-weight: bold;
1769+
font-weight: var(--font-weight-heading);
17701770
color: var(--color-text-maxcontrast);
17711771
}
17721772
}

dist/core-common.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-common.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-unified-search.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-unified-search.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)