refactor: add PHP 8.3 types to BC-safe class constants

PHP 8.3 allows class constants to declare a type. Adopt it where doing so
cannot break third-party apps.

Typing an inheritable constant is a hard BC break: a subclass that
redeclares it untyped fails to load with "Type of C::FOO must be
compatible with P::FOO of type string". Changes are therefore limited to
constants that cannot be redeclared by a subclass:

  - private const (not inherited)
  - final public/protected const
  - constants declared in a final class or an enum

Interface constants, trait constants, and public/protected constants in
non-final (including abstract) classes are left untyped, as is all of
lib/public (OCP) and lib/unstable (NCU).

One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX
constants of the app-internal CalDAV import helpers (TextImporter,
XmlImporter) are typed as well; these classes are not public API and
have no subclasses.

Only string, int and array are used. float is avoided because it would
silently coerce an int literal and change === comparisons. No constant
name or value is modified: every changed line adds only the type token,
so runtime behaviour is unchanged.

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Author: solracsf

apps/contactsinteraction/lib/Migration/FixVcardCategory.php

@@ -20,7 +20,7 @@
 
 class FixVcardCategory implements IRepairStep {
 
-	private const CARDS_PER_BATCH = 5000;
+	private const int CARDS_PER_BATCH = 5000;
 
 	public function __construct(
 		private readonly IDBConnection $connection,

apps/dav/lib/BackgroundJob/CleanupOrphanedChildrenJob.php

@@ -23,7 +23,7 @@ class CleanupOrphanedChildrenJob extends QueuedJob {
 	public const ARGUMENT_PARENT_ID = 'parentId';
 	public const ARGUMENT_LOG_MESSAGE = 'logMessage';
 
-	private const BATCH_SIZE = 1000;
+	private const int BATCH_SIZE = 1000;
 
 	public function __construct(
 		ITimeFactory $time,

apps/dav/lib/BackgroundJob/FederatedCalendarPeriodicSyncJob.php

@@ -18,7 +18,7 @@
 use Psr\Log\LoggerInterface;
 
 class FederatedCalendarPeriodicSyncJob extends TimedJob {
-	private const DOWNLOAD_LIMIT = 500;
+	private const int DOWNLOAD_LIMIT = 500;
 
 	public function __construct(
 		ITimeFactory $time,

apps/dav/lib/CalDAV/CalDavBackend.php

@@ -177,7 +177,7 @@ class CalDavBackend extends AbstractBackend implements SyncSupport, Subscription
 	 *
 	 * @see \OCP\Calendar\ICalendarQuery
 	 */
-	private const INDEXED_PROPERTIES = [
+	private const array INDEXED_PROPERTIES = [
 		'CATEGORIES',
 		'COMMENT',
 		'DESCRIPTION',
@@ -191,7 +191,7 @@ class CalDavBackend extends AbstractBackend implements SyncSupport, Subscription
 	];
 
 	/** @var array parameters to index */
-	private const INDEXED_PARAMETERS = [
+	private const array INDEXED_PARAMETERS = [
 		'ATTENDEE' => ['CN'],
 		'ORGANIZER' => ['CN'],
 	];

apps/dav/lib/CalDAV/CalendarImpl.php

@@ -41,8 +41,8 @@ public function __construct(
 	) {
 	}
 
-	private const DAV_PROPERTY_USER_ADDRESS = '{http://sabredav.org/ns}email-address';
-	private const DAV_PROPERTY_USER_ADDRESSES = '{urn:ietf:params:xml:ns:caldav}calendar-user-address-set';
+	private const string DAV_PROPERTY_USER_ADDRESS = '{http://sabredav.org/ns}email-address';
+	private const string DAV_PROPERTY_USER_ADDRESSES = '{urn:ietf:params:xml:ns:caldav}calendar-user-address-set';
 
 	/**
 	 * @return string defining the technical unique key

apps/dav/lib/CalDAV/EventComparisonService.php

@@ -16,7 +16,7 @@
 class EventComparisonService {
 
 	/** @var string[] */
-	private const EVENT_DIFF = [
+	private const array EVENT_DIFF = [
 		'RECURRENCE-ID',
 		'RRULE',
 		'SEQUENCE',

apps/dav/lib/CalDAV/Federation/FederatedCalendar.php

@@ -23,9 +23,9 @@
 
 class FederatedCalendar implements ICalendar, IProperties, IMultiGet {
 
-	private const CALENDAR_TYPE = CalDavBackend::CALENDAR_TYPE_FEDERATED;
-	private const DAV_PROPERTY_CALENDAR_LABEL = '{DAV:}displayname';
-	private const DAV_PROPERTY_CALENDAR_COLOR = '{http://apple.com/ns/ical/}calendar-color';
+	private const int CALENDAR_TYPE = CalDavBackend::CALENDAR_TYPE_FEDERATED;
+	private const string DAV_PROPERTY_CALENDAR_LABEL = '{DAV:}displayname';
+	private const string DAV_PROPERTY_CALENDAR_COLOR = '{http://apple.com/ns/ical/}calendar-color';
 
 	private string $principalUri;
 	private string $calendarUri;

apps/dav/lib/CalDAV/Federation/FederatedCalendarSyncService.php

@@ -23,7 +23,7 @@
 class FederatedCalendarSyncService extends ASyncService {
 	use TTransactional;
 
-	private const SYNC_TOKEN_PREFIX = 'http://sabre.io/ns/sync/';
+	private const string SYNC_TOKEN_PREFIX = 'http://sabre.io/ns/sync/';
 
 	public function __construct(
 		IClientService $clientService,

apps/dav/lib/CalDAV/ICSExportPlugin/ICSExportPlugin.php

@@ -21,7 +21,7 @@
  */
 class ICSExportPlugin extends \Sabre\CalDAV\ICSExportPlugin {
 	/** @var string */
-	private const DEFAULT_REFRESH_INTERVAL = 'PT4H';
+	private const string DEFAULT_REFRESH_INTERVAL = 'PT4H';
 
 	/**
 	 * ICSExportPlugin constructor.

apps/dav/lib/CalDAV/Import/TextImporter.php

@@ -12,9 +12,9 @@
 
 class TextImporter {
 
-	public const OBJECT_PREFIX = 'BEGIN:VCALENDAR' . PHP_EOL;
-	public const OBJECT_SUFFIX = PHP_EOL . 'END:VCALENDAR';
-	private const COMPONENT_TYPES = ['VEVENT', 'VTODO', 'VJOURNAL', 'VTIMEZONE'];
+	public const string OBJECT_PREFIX = 'BEGIN:VCALENDAR' . PHP_EOL;
+	public const string OBJECT_SUFFIX = PHP_EOL . 'END:VCALENDAR';
+	private const array COMPONENT_TYPES = ['VEVENT', 'VTODO', 'VJOURNAL', 'VTIMEZONE'];
 
 	private bool $analyzed = false;
 	private array $structure = ['VCALENDAR' => [], 'VEVENT' => [], 'VTODO' => [], 'VJOURNAL' => [], 'VTIMEZONE' => []];