fix: improve check if external storage backend is local

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

apps/files_external/lib/Controller/GlobalStoragesController.php

@@ -28,6 +28,7 @@
 namespace OCA\Files_External\Controller;
 
 use OCA\Files_External\NotFoundException;
+use OCA\Files_External\Service\BackendService;
 use OCA\Files_External\Service\GlobalStoragesService;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
@@ -62,7 +63,8 @@ public function __construct(
 		ILogger $logger,
 		IUserSession $userSession,
 		IGroupManager $groupManager,
-		IConfig $config
+		IConfig $config,
+		BackendService $backendService
 	) {
 		parent::__construct(
 			$AppName,
@@ -72,7 +74,8 @@ public function __construct(
 			$logger,
 			$userSession,
 			$groupManager,
-			$config
+			$config,
+			$backendService
 		);
 	}
 

apps/files_external/lib/Controller/StoragesController.php

@@ -31,9 +31,11 @@
 use OCA\Files_External\Lib\Auth\AuthMechanism;
 use OCA\Files_External\Lib\Backend\Backend;
 use OCA\Files_External\Lib\DefinitionParameter;
+use OCA\Files_External\Lib\Backend\Local;
 use OCA\Files_External\Lib\InsufficientDataForMeaningfulAnswerException;
 use OCA\Files_External\Lib\StorageConfig;
 use OCA\Files_External\NotFoundException;
+use OCA\Files_External\Service\BackendService;
 use OCA\Files_External\Service\StoragesService;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
@@ -85,6 +87,11 @@ abstract class StoragesController extends Controller {
 	 */
 	protected $config;
 
+	/**
+	 * @var BackendService
+	 */
+	protected $backendService;
+
 	/**
 	 * Creates a new storages controller.
 	 *
@@ -102,7 +109,8 @@ public function __construct(
 		ILogger $logger,
 		IUserSession $userSession,
 		IGroupManager $groupManager,
-		IConfig $config
+		IConfig $config,
+		BackendService $backendService
 	) {
 		parent::__construct($AppName, $request);
 		$this->l10n = $l10n;
@@ -111,6 +119,7 @@ public function __construct(
 		$this->userSession = $userSession;
 		$this->groupManager = $groupManager;
 		$this->config = $config;
+		$this->backendService = $backendService;
 	}
 
 	/**
@@ -138,7 +147,7 @@ protected function createStorage(
 		$priority = null
 	) {
 		$canCreateNewLocalStorage = $this->config->getSystemValue('files_external_allow_create_new_local', true);
-		if (!$canCreateNewLocalStorage && $backend === 'local') {
+		if (!$canCreateNewLocalStorage && $this->backendService->getBackend($backend) instanceof Local) {
 			return new DataResponse(
 				[
 					'message' => $this->l10n->t('Forbidden to manage local mounts')

apps/files_external/lib/Controller/UserGlobalStoragesController.php

@@ -33,6 +33,7 @@
 use OCA\Files_External\Lib\InsufficientDataForMeaningfulAnswerException;
 use OCA\Files_External\Lib\StorageConfig;
 use OCA\Files_External\NotFoundException;
+use OCA\Files_External\Service\BackendService;
 use OCA\Files_External\Service\UserGlobalStoragesService;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
@@ -66,7 +67,8 @@ public function __construct(
 		ILogger $logger,
 		IUserSession $userSession,
 		IGroupManager $groupManager,
-		IConfig $config
+		IConfig $config,
+		BackendService $backendService
 	) {
 		parent::__construct(
 			$AppName,
@@ -76,7 +78,8 @@ public function __construct(
 			$logger,
 			$userSession,
 			$groupManager,
-			$config
+			$config,
+			$backendService,
 		);
 	}
 

apps/files_external/lib/Controller/UserStoragesController.php

@@ -32,6 +32,7 @@
 use OCA\Files_External\Lib\Backend\Backend;
 use OCA\Files_External\Lib\StorageConfig;
 use OCA\Files_External\NotFoundException;
+use OCA\Files_External\Service\BackendService;
 use OCA\Files_External\Service\UserStoragesService;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
@@ -65,7 +66,8 @@ public function __construct(
 		ILogger $logger,
 		IUserSession $userSession,
 		IGroupManager $groupManager,
-		IConfig $config
+		IConfig $config,
+		BackendService $backendService
 	) {
 		parent::__construct(
 			$AppName,
@@ -75,7 +77,8 @@ public function __construct(
 			$logger,
 			$userSession,
 			$groupManager,
-			$config
+			$config,
+			$backendService,
 		);
 	}