Skip to content

Commit d7ed0f7

Browse files
fixup! feat: contacts import ocs
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
1 parent 875d2e6 commit d7ed0f7

4 files changed

Lines changed: 4 additions & 28 deletions

File tree

apps/dav/lib/CardDAV/CardDavBackend.php

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ public function getCardByUid(int $addressBookId, string $uid): ?array {
576576

577577
return $row;
578578
}
579-
579+
580580
/**
581581
* Returns a list of cards.
582582
*
@@ -624,30 +624,6 @@ public function getMultipleCards($addressBookId, array $uris) {
624624
return $cards;
625625
}
626626

627-
public function getCardByUID(int $addressBookId, string $uid) {
628-
$query = $this->db->getQueryBuilder();
629-
$query->select('*')
630-
->from($this->dbCardsTable)
631-
->where($query->expr()->eq('addressbookid', $query->createNamedParameter($addressBookId)))
632-
->andWhere($query->expr()->eq('uid', $query->createNamedParameter($uid)))
633-
->setMaxResults(1);
634-
635-
$result = $query->executeQuery();
636-
$row = $result->fetchAssociative();
637-
if (!$row) {
638-
return false;
639-
}
640-
$row['etag'] = '"' . $row['etag'] . '"';
641-
642-
$modified = false;
643-
$row['carddata'] = $this->readBlob($row['carddata'], $modified);
644-
if ($modified) {
645-
$row['size'] = strlen($row['carddata']);
646-
}
647-
648-
return $row;
649-
}
650-
651627
/**
652628
* Creates a new card.
653629
*

apps/dav/lib/CardDAV/Import/ImportCountEvent.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
final readonly class ImportCountEvent implements ImportEvent {
1212
public function __construct(
13-
public int $vcard
13+
public int $vcard,
1414
) {
1515
}
1616

apps/dav/lib/CardDAV/Import/ImportService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public function importProcess($source, AddressBookImpl $addressBook, ContactsImp
132132
$objectEntry = $this->backend->getCardByUID($addressBookId, $uid);
133133
$objectData = $vObject->serialize();
134134
try {
135-
if ($objectEntry === false) {
135+
if ($objectEntry === null) {
136136
$objectUri = UUIDUtil::getUUID();
137137
$this->backend->createCard(
138138
$addressBookId,

apps/dav/lib/Controller/ContactsImportController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
use OCP\AppFramework\OCSController;
2424
use OCP\Contacts\ContactsImportOptions;
2525
use OCP\Contacts\IManager;
26+
use OCP\IAddressBookWritable;
2627
use OCP\IGroupManager;
2728
use OCP\IRequest;
2829
use OCP\ITempManager;
2930
use OCP\IUserManager;
3031
use OCP\IUserSession;
31-
use OCP\IAddressBookWritable;
3232

3333
class ContactsImportController extends OCSController {
3434

0 commit comments

Comments
 (0)