Merge pull request #63126 from nextcloud/backport/63124/stable33

[stable33] backports ldap fixes

Author: blizzz

apps/user_ldap/lib/Configuration.php

@@ -234,7 +234,9 @@ public function setConfiguration(array $config, ?array &$applied = null): void {
 
 			$setMethod = 'setValue';
 			switch ($key) {
+				case 'ldapAgentName':
 				case 'ldapAgentPassword':
+					$val = \filter_var($val, FILTER_UNSAFE_RAW, FILTER_FLAG_STRIP_LOW);
 					$setMethod = 'setRawValue';
 					break;
 				case 'homeFolderNamingRule':

apps/user_ldap/tests/ConfigurationTest.php

@@ -54,6 +54,9 @@ public static function configurationDataProvider(): array {
 
 		$password = ' such a passw0rd ';
 
+		$dnWithCrlf = "cn=admin\r\nset foo bar\r\n,dc=example,dc=org";
+		$expectedDn = 'cn=adminset foo bar,dc=example,dc=org';
+
 		return [
 			'set general base' => ['ldapBase', $inputWithDN, $expectWithDN],
 			'set user base' => ['ldapBaseUsers', $inputWithDN, $expectWithDN],
@@ -69,6 +72,7 @@ public static function configurationDataProvider(): array {
 			'set login filter attributes' => ['ldapLoginFilterAttributes', $inputNames, $expectedNames],
 
 			'set agent password' => ['ldapAgentPassword', $password, $password],
+			'set agent name strips CRLF' => ['ldapAgentName', $dnWithCrlf, $expectedDn],
 
 			'set home folder, variant 1' => ['homeFolderNamingRule', $inputHomeFolder[0], $expectedHomeFolder[0]],
 			'set home folder, variant 2' => ['homeFolderNamingRule', $inputHomeFolder[1], $expectedHomeFolder[1]],