chore: Add review feedback

Throw when one of the headers are empty

Enumerate all the allowed algorithms in th NATIVE constant

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Micke Nordin <kano@sunet.se>

Author: mickenordin

lib/private/Security/Signature/Model/Rfc9421IncomingSignedRequest.php

@@ -306,6 +306,9 @@ private function collectHeaders(): array {
 			if ($value === '' && strtolower($component) === 'host') {
 				$value = $this->request->getServerHost();
 			}
+			if ($value === '') {
+				throw new IncomingRequestException('covered header is missing or empty: ' . $component);
+			}
 			$out[strtolower($component)] = $value;
 		}
 		return $out;

lib/private/Security/Signature/Rfc9421/Algorithm.php

@@ -31,6 +31,8 @@
 final class Algorithm {
 	public const NATIVE = [
 		'rsa-v1_5-sha256',
+		'rsa-v1_5-sha384',
+		'rsa-v1_5-sha512',
 		'ecdsa-p256-sha256',
 		'ecdsa-p384-sha384',
 		'ed25519',