fix(SharingManager): Skip interaction checks if checks are overridden

Signed-off-by: provokateurin <kate@provokateurin.de>

Author: provokateurin

lib/private/Sharing/SharingManager.php

@@ -108,12 +108,12 @@ public function searchRecipients(ShareAccessContext $accessContext, ?array $reci
 		} else {
 			$recipientTypes = array_values(array_filter(
 				$recipientTypes,
-				static fn (IShareRecipientType $recipientType): bool => $recipientType instanceof IShareRecipientTypeSearch,
+				static fn(IShareRecipientType $recipientType): bool => $recipientType instanceof IShareRecipientTypeSearch,
 			));
 		}
 
 		return array_merge(...array_map(
-			static fn (IShareRecipientTypeSearch $recipientType): array => $recipientType->searchRecipients($accessContext, $query, $limit, $offset),
+			static fn(IShareRecipientTypeSearch $recipientType): array => $recipientType->searchRecipients($accessContext, $query, $limit, $offset),
 			$recipientTypes,
 		));
 	}
@@ -201,10 +201,12 @@ public function addShareSource(ShareAccessContext $accessContext, string $id, Sh
 			throw new ShareInvalidException('Invalid source: ' . $source->value . ' ' . $source->class, $this->l10n->t('The source does not exist.'));
 		}
 
-		$share = $this->getShare($accessContext, $id, $backend);
-		$sources = $share->sources;
-		$sources[] = $source;
-		$this->validateInteraction($accessContext, $owner, $sources, $share->getEnabledPermissions(), $share->recipients);
+		if (!$accessContext->overrideChecks) {
+			$share = $this->getShare($accessContext, $id, $backend);
+			$sources = $share->sources;
+			$sources[] = $source;
+			$this->validateInteraction($accessContext, $owner, $sources, $share->getEnabledPermissions(), $share->recipients);
+		}
 
 		$backend->addShareSource($id, $source);
 	}
@@ -277,10 +279,12 @@ public function addShareRecipient(ShareAccessContext $accessContext, string $id,
 			throw new ShareInvalidException('Invalid recipient: ' . $recipient->value . ' ' . $recipient->class . ' ' . ($recipient->instance ?? 'local'), $this->l10n->t('The recipient does not exist.'));
 		}
 
-		$share ??= $this->getShare($accessContext, $id, $backend);
-		$recipients = $share->recipients;
-		$recipients[] = $recipient;
-		$this->validateInteraction($accessContext, $owner, $share->sources, $share->getEnabledPermissions(), $recipients);
+		if (!$accessContext->overrideChecks) {
+			$share ??= $this->getShare($accessContext, $id, $backend);
+			$recipients = $share->recipients;
+			$recipients[] = $recipient;
+			$this->validateInteraction($accessContext, $owner, $share->sources, $share->getEnabledPermissions(), $recipients);
+		}
 
 		$backend->addShareRecipient($id, $currentUser, $recipient);
 	}
@@ -423,12 +427,12 @@ public function updateSharePermission(ShareAccessContext $accessContext, string
 			throw new RuntimeException('The permission type is not registered: ' . $permission->class);
 		}
 
-		$share = $this->getShare($accessContext, $id, $backend);
-
-		$permissions = $share->permissions;
-		$permissions[$permission->class] = $permission;
-
-		$this->validateInteraction($accessContext, $owner, $share->sources, array_filter($permissions, static fn (SharePermission $permission): bool => $permission->enabled), $share->recipients);
+		if (!$accessContext->overrideChecks) {
+			$share = $this->getShare($accessContext, $id, $backend);
+			$permissions = $share->permissions;
+			$permissions[$permission->class] = $permission;
+			$this->validateInteraction($accessContext, $owner, $share->sources, array_filter($permissions, static fn(SharePermission $permission): bool => $permission->enabled), $share->recipients);
+		}
 
 		$backend->updateSharePermission($id, $permission);
 
@@ -547,6 +551,7 @@ private function getBackend(?string $id): ISharingBackend {
 	}
 
 	// TODO: Support IShareOwnerlessMount
+
 	/**
 	 * @throws ShareOperationForbiddenException
 	 */
@@ -600,7 +605,7 @@ private function validateReshareOperation(ShareAccessContext $accessContext, Sha
 	 * @throws ShareInvalidException
 	 */
 	private function validateInteraction(ShareAccessContext $accessContext, ShareUser $owner, array $sources, array $enabledPermissions, array $recipients): void {
-		$action = new ShareAction(null, array_values(array_map(static fn (SharePermission $permission): string => $permission->class, $enabledPermissions)));
+		$action = new ShareAction(null, array_values(array_map(static fn(SharePermission $permission): string => $permission->class, $enabledPermissions)));
 
 		$usersToCheck = [];
 		if ($owner->instance === null && ($ownerUser = $this->userManager->get($owner->userId)) !== null) {