Skip to content

Commit a314453

Browse files
committed
fix: Finish cleanup
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 parent 40f474e commit a314453

10 files changed

Lines changed: 289 additions & 437 deletions

File tree

apps/cloud_federation_api/appinfo/info.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@
2222
<nextcloud min-version="35" max-version="35"/>
2323
</dependencies>
2424

25-
<background-jobs>
26-
<job>OCA\CloudFederationAPI\BackgroundJob\CleanupExpiredOcmTokensJob</job>
27-
</background-jobs>
2825
<repair-steps>
2926
<post-migration>
3027
<step>OCA\CloudFederationAPI\Migration\DropFederatedInvitesTable</step>

apps/cloud_federation_api/lib/AppInfo/Application.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@
99

1010
namespace OCA\CloudFederationAPI\AppInfo;
1111

12-
use OCA\CloudFederationAPI\Listener\ShareDeletedListener;
1312
use OCP\AppFramework\App;
1413
use OCP\AppFramework\Bootstrap\IBootContext;
1514
use OCP\AppFramework\Bootstrap\IBootstrap;
1615
use OCP\AppFramework\Bootstrap\IRegistrationContext;
17-
use OCP\Share\Events\ShareDeletedEvent;
1816

1917
class Application extends App implements IBootstrap {
2018
public const APP_ID = 'cloud_federation_api';

apps/cloud_federation_api/lib/Controller/RequestHandlerController.php

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
use OC\Authentication\Token\PublicKeyTokenProvider;
1212
use OC\OCM\OCMSignatoryManager;
1313
use OCA\CloudFederationAPI\Config;
14-
use OCA\CloudFederationAPI\Db\OcmTokenMapMapper;
1514
use OCA\CloudFederationAPI\ResponseDefinitions;
1615
use OCP\AppFramework\Controller;
1716
use OCP\AppFramework\Http;
@@ -20,7 +19,6 @@
2019
use OCP\AppFramework\Http\Attribute\OpenAPI;
2120
use OCP\AppFramework\Http\Attribute\PublicPage;
2221
use OCP\AppFramework\Http\JSONResponse;
23-
use OCP\AppFramework\Utility\ITimeFactory;
2422
use OCP\EventDispatcher\IEventDispatcher;
2523
use OCP\Federation\Exceptions\ActionNotSupportedException;
2624
use OCP\Federation\Exceptions\AuthenticationFailedException;
@@ -470,14 +468,7 @@ private function resolveNotificationIdentity(string $resourceType, array $notifi
470468
try {
471469
$provider = $this->cloudFederationProviderManager->getCloudFederationProvider($resourceType);
472470
if ($provider instanceof ISignedCloudFederationProvider || $provider instanceof \NCU\Federation\ISignedCloudFederationProvider) {
473-
$identity = $provider->getFederationIdFromSharedSecret($sharedSecret, $notification);
474-
if ($identity === '') {
475-
$tokenProvider = Server::get(PublicKeyTokenProvider::class);
476-
$accessTokenDb = $tokenProvider->getToken($sharedSecret);
477-
$mapping = Server::get(OcmTokenMapMapper::class)->getByAccessTokenId($accessTokenDb->getId());
478-
$identity = $provider->getFederationIdFromSharedSecret($mapping->getRefreshToken(), $notification);
479-
}
480-
return $identity;
471+
return $provider->getFederationIdFromSharedSecret($sharedSecret, $notification);
481472
}
482473
$this->logger->debug('cloud federation provider {provider} does not implement ISignedCloudFederationProvider', ['provider' => $provider::class]);
483474
} catch (\Exception $e) {

apps/cloud_federation_api/tests/BackgroundJob/CleanupExpiredOcmTokensJobTest.php

Lines changed: 0 additions & 42 deletions
This file was deleted.

0 commit comments

Comments
 (0)