fix: reword trashbin:expire help and drop the metadata assertion test

Per review: "Processes deleted files" was confusing since the command deletes
expired files rather than processing them. Description and help now say so
directly, and the test that pinned the exact wording is removed.

Author: mvanhorn

apps/files_trashbin/lib/Command/ExpireTrash.php

@@ -37,8 +37,8 @@ protected function configure(): void {
 		parent::configure();
 		$this
 			->setName('trashbin:expire')
-			->setDescription('Delete eligible trashbin entries according to the configured retention and space policy')
-			->setHelp('Processes deleted files according to the configured trashbin retention and space policy. This does not disable the trashbin or unconditionally empty it.')
+			->setDescription('Delete expired files from the trashbin')
+			->setHelp('Deletes expired files from the trashbin according to the configured retention and space policy. This does not disable the trashbin or unconditionally empty it.')
 			->addArgument(
 				'user_id',
 				InputArgument::OPTIONAL | InputArgument::IS_ARRAY,

apps/files_trashbin/tests/Command/ExpireTrashTest.php

@@ -67,28 +67,6 @@ protected function tearDown(): void {
 		parent::tearDown();
 	}
 
-	public function testCommandMetadata(): void {
-		$command = new ExpireTrash(
-			Server::get(IUserManager::class),
-			$this->expiration,
-			Server::get(SetupManager::class),
-			Server::get(IRootFolder::class),
-		);
-
-		$this->assertSame(
-			'Delete eligible trashbin entries according to the configured retention and space policy',
-			$command->getDescription(),
-		);
-		$this->assertSame(
-			'Processes deleted files according to the configured trashbin retention and space policy. This does not disable the trashbin or unconditionally empty it.',
-			$command->getHelp(),
-		);
-		$this->assertSame(
-			'Limit processing to the given user ID(s); if no user ID is given, all users are processed',
-			$command->getDefinition()->getArgument('user_id')->getDescription(),
-		);
-	}
-
 	#[DataProvider(methodName: 'retentionObligationProvider')]
 	public function testRetentionObligation(string $obligation, string $quota, int $elapsed, int $fileSize, bool $shouldExpire): void {
 		$this->config->setSystemValues(['trashbin_retention_obligation' => $obligation]);