fix: Fix clearing the new password

"newPassword" is internally delegated by the share object to
"_share.newPassword" through getter and setter properties. Therefore
deleting "newPassword" has no effect, as there is no such attribute,
and it should be set to undefined instead.

Now that "newPassword" is correctly cleared "Set password" is no longer
checked if the share of a password is removed, the share is updated, and
the share is customized again (without reloading the page in the
meantime).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Author: danxuliu

apps/files_sharing/src/mixins/SharesMixin.js

@@ -327,7 +327,7 @@ export default {
 						if (propertyNames.includes('password')) {
 							// reset password state after sync
 							this.share.password = this.share.newPassword || undefined
-							this.$delete(this.share, 'newPassword')
+							this.$set(this.share, 'newPassword', undefined)
 
 							// updates password expiration time after sync
 							this.share.passwordExpirationTime = updatedShare.password_expiration_time
@@ -398,7 +398,7 @@ export default {
 				if (this.share.newPassword === this.share.password) {
 					this.share.password = ''
 				}
-				this.$delete(this.share, 'newPassword')
+				this.$set(this.share, 'newPassword', undefined)
 			}
 
 			// re-open menu if closed

apps/files_sharing/src/views/SharingDetailsTab.vue

@@ -1258,7 +1258,7 @@ export default {
 		 */
 		onPasswordChange(password) {
 			if (password === '') {
-				this.$delete(this.share, 'newPassword')
+				this.$set(this.share, 'newPassword', undefined)
 				this.passwordError = this.isNewShare && this.isPasswordEnforced
 				return
 			}

tests/playwright/e2e/files_sharing/public-share/share-editor.spec.ts

@@ -103,6 +103,27 @@ test.describe('files_sharing: Link share editor', () => {
 		await expect(sharingTab.checkbox('Note to recipient')).not.toBeChecked()
 		await expect(sharingTab.checkbox('Custom permissions')).not.toBeChecked()
 	})
+
+	test('the password is unchecked after clearing and saving it', async ({ filesListPage, sharingTab }) => {
+		await openSharingPanel(filesListPage, sharingTab, 'test')
+
+		await sharingTab.openLinkShareDetails()
+		await sharingTab.openAdvancedSettings()
+		await expect(sharingTab.checkbox('Set password')).not.toBeChecked()
+		await sharingTab.setCheckbox('Set password', true)
+		// A password is automatically generated and added to the input
+		await sharingTab.save()
+
+		await sharingTab.openLinkShareDetails()
+		await sharingTab.openAdvancedSettings()
+		await expect(sharingTab.checkbox('Set password')).toBeChecked()
+		await sharingTab.setCheckbox('Set password', false)
+		await sharingTab.save()
+
+		await sharingTab.openLinkShareDetails()
+		await sharingTab.openAdvancedSettings()
+		await expect(sharingTab.checkbox('Set password')).not.toBeChecked()
+	})
 })
 
 test.describe('files_sharing: Email share editor', () => {