chore: resolve psalm issues

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

build/psalm-baseline.xml

@@ -4101,12 +4101,6 @@
     <TypeDoesNotContainType>
       <code><![CDATA[ctype_digit($this->dbPort)]]></code>
     </TypeDoesNotContainType>
-    <UndefinedThisPropertyFetch>
-      <code><![CDATA[$this->dbprettyname]]></code>
-      <code><![CDATA[$this->dbprettyname]]></code>
-      <code><![CDATA[$this->dbprettyname]]></code>
-      <code><![CDATA[$this->dbprettyname]]></code>
-    </UndefinedThisPropertyFetch>
   </file>
   <file src="lib/private/Share20/DefaultShareProvider.php">
     <FalsableReturnStatement>

lib/private/Setup/AbstractDatabase.php

@@ -25,6 +25,8 @@ abstract class AbstractDatabase {
 	 */
 	protected const array CONNECTION_ENCRYPTION_OPTIONS = ['dbdriveroptions'];
 
+	protected string $dbprettyname = 'abstract';
+
 	protected string $dbUser;
 	protected string $dbPassword;
 	protected string $dbName;

lib/private/Setup/OCI.php

@@ -11,7 +11,7 @@
 use OC\DatabaseSetupException;
 
 class OCI extends AbstractDatabase {
-	public $dbprettyname = 'Oracle';
+	public string $dbprettyname = 'Oracle';
 
 	protected $dbtablespace;
 

lib/private/Setup/PostgreSQL.php

@@ -14,7 +14,7 @@
 use OC\DB\QueryBuilder\Literal;
 
 class PostgreSQL extends AbstractDatabase {
-	public $dbprettyname = 'PostgreSQL';
+	public string $dbprettyname = 'PostgreSQL';
 
 	// #[\Override] TODO: Uncomment this when we only support PHP 8.5+ support
 	protected const array CONNECTION_ENCRYPTION_OPTIONS = [...parent::CONNECTION_ENCRYPTION_OPTIONS, 'pgsql_ssl'];